Skip to content

drivers: clock_control: clock_stm32_ll_h7: Make LSE driving configurable #44736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2022
Merged

drivers: clock_control: clock_stm32_ll_h7: Make LSE driving configurable #44736

merged 1 commit into from
Apr 29, 2022

Conversation

@benediktibk
Copy link
Contributor

@benediktibk benediktibk commented Apr 11, 2022 •
edited
Loading

Make the LSE driving capability of a STM32H7 configurable via devicetree.
Fixes #44737.

Signed-off-by: Benedikt Schmidt [email protected]

@github-actions github-actions bot added area: API Changes to public APIs area: Devicetree area: Devicetree Binding PR modifies or adds a Device Tree binding platform: STM32 ST Micro STM32 labels Apr 11, 2022
@benediktibk
Copy link
Contributor Author

benediktibk commented Apr 11, 2022

Tested on a H735.
Reference manual checked for:

  • STM32H723XX
  • STM32H735XX
  • STM32H725XX
  • STM32H7A3XX
  • STM32H7B3XX
  • STM32H743XX
  • STM32H753XX
  • STM32H750XX
  • STM32H745XX
  • STM32H747XX

@benediktibk benediktibk mentioned this pull request Apr 11, 2022
Closed
@benediktibk benediktibk force-pushed the add_h7_lse_driving_cap branch from 0d164ee to 8a6a5c0 Compare April 11, 2022 09:40
@FRASTM
Copy link
Contributor

FRASTM commented Apr 12, 2022 •
edited
Loading

@benediktibk thanks for adding this property.
Could it be extended in other stm32 mcus which have that drive feature on their LSE (stm32F0, stm32G4 etc) in a similar way,

@benediktibk
Copy link
Contributor Author

benediktibk commented Apr 12, 2022

My results from checking the reference manuals from the already available SoCs in zephyr:

has the feature:

  • stm32f030x4
  • stm32f030x8
  • stm32f030xc
  • stm32f070xb
  • stm32f031x6
  • stm32f051x8
  • stm32f072xb
  • stm32f091xc
  • stm32f098xx
  • stm32f302x8
  • stm32f303x8
  • stm32f303xc
  • stm32f303xe
  • stm32f334x8
  • stm32f373xc
  • stm32u575xx
  • stm32u585xx
  • stm32wb55xx
  • stm32f723xx
  • stm32f745xx
  • stm32f746xx
  • stm32f756xx
  • stm32f767xx
  • stm32f769xx
  • stm32g0b0xx
  • stm32g030xx
  • stm32g050xx
  • stm32g070xx
  • stm32g0b1xx
  • stm32g0c1xx
  • stm32g031xx
  • stm32g041xx
  • stm32g051xx
  • stm32g061xx
  • stm32g071xx
  • stm32g081xx
  • stm32g4a1xx
  • stm32g431rb
  • stm32g441xx
  • stm32g473xx
  • stm32g474re
  • stm32g483xx
  • stm32g484xx
  • stm32g491xx
  • stm32l010xb
  • stm32l011xx
  • stm32l031xx
  • stm32l051xx
  • stm32l071xx
  • stm32l072xx
  • stm32l053xx
  • stm32l073xx
  • stm32l4r5xx
  • stm32l4r9xx
  • stm32l4s5xx
  • stm32l412xx
  • stm32l422xx
  • stm32l432xx
  • stm32l433xx
  • stm32l452xx
  • stm32l462xx
  • stm32l471xx
  • stm32l475xx
  • stm32l476xx
  • stm32l496xx
  • stm32l552xx
  • stm32l562xx
  • stm32wl54xx
  • stm32wl55xx
  • stm32wle4xx
  • stm32wle5xx
  • stm32mp15_m4

does not have the feature:

  • stm32f100xx
  • stm32f103xx
  • stm32f105xc
  • stm32f107xc
  • stm32f205xx
  • stm32f207xx
  • stm32f401xc
  • stm32f401xe
  • stm32f405xx
  • stm32f407xx
  • stm32f415xx
  • stm32f417xx
  • stm32f437xx
  • stm32f427xx
  • stm32f429xx
  • stm32f410xx
  • stm32f411xe
  • stm32f412xx
  • stm32f413xx
  • stm32f446xx
  • stm32f469xx
  • stm32l151x8a
  • stm32l151xb
  • stm32l151xba
  • stm32l151xc
  • stm32l152xc
  • stm32l152xe

Hence, I would continue to add the following bindings, similar to the one of the H7 series:

  • st,stm32f0-lse-clock.yaml
  • st,stm32f3-lse-clock.yaml
  • st,stm32u5-lse-clock.yaml
  • st,stm32wb-lse-clock.yaml
  • st,stm32f7-lse-clock.yaml
  • st,stm32g0-lse-clock.yaml
  • st,stm32g4-lse-clock.yaml
  • st,stm32l0-lse-clock.yaml
  • st,stm32l4-lse-clock.yaml
  • st,stm32l5-lse-clock.yaml
  • st,stm32wl-lse-clock.yaml

Does this sound reasonable to you @FRASTM ?

@github-actions github-actions bot added the area: Timer Timer label Apr 13, 2022
@benediktibk
Copy link
Contributor Author

benediktibk commented Apr 13, 2022

While implementing this I realized that for some SoCs the LSE is not really implemented, at least I couldn't find a call to LL_RCC_LSE_Enable:

  • F0
  • F3
  • F7
  • G0
  • L0

I still went ahead and at least added the properties for them.

And there is one more additional problem, stm32_counter kinda is in conflict with the LSE configuration with the clock control. Seems problematic, but for the moment I kept it as it is.

@benediktibk
Copy link
Contributor Author

benediktibk commented Apr 13, 2022

The LPTIM timer as well enables LSE. I feel like only the clock control should enable LSE?

@benediktibk benediktibk force-pushed the add_h7_lse_driving_cap branch 2 times, most recently from 6615cd4 to fb28411 Compare April 13, 2022 12:38
@FRASTM
Copy link
Contributor

FRASTM commented Apr 13, 2022

While implementing this I realized that for some SoCs the LSE is not really implemented, at least I couldn't find a call to LL_RCC_LSE_Enable:

  • F0
  • F3
  • F7
  • G0
  • L0

I still went ahead and at least added the properties for them.

And there is one more additional problem, stm32_counter kinda is in conflict with the LSE configuration with the clock control. Seems problematic, but for the moment I kept it as it is.

Yes, this might change with the coming PR #44312

@FRASTM
Copy link
Contributor

FRASTM commented Apr 13, 2022 •
edited
Loading

@benediktibk thanks for listing all the stm32 and giving that exhaustive view.

mbolivar-nordic
mbolivar-nordic reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No hard objections on the binding; one suggestion.

mbolivar-nordic
mbolivar-nordic reviewed Apr 14, 2022
View reviewed changes
@benediktibk benediktibk force-pushed the add_h7_lse_driving_cap branch from c6575ea to 21869a3 Compare April 19, 2022 09:33
@erwango
Copy link
Member

erwango commented Apr 20, 2022

The LPTIM timer as well enables LSE. I feel like only the clock control should enable LSE?

This is right. On going proposal for this is #42097.

erwango
erwango requested changes Apr 20, 2022
View reviewed changes
Copy link
Member

@erwango erwango left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One main request.
Also, you'll need to rebase on top of #44312 which will have some impact on your change.

@benediktibk benediktibk force-pushed the add_h7_lse_driving_cap branch 2 times, most recently from 5872d39 to 7539856 Compare April 21, 2022 07:30
erwango
erwango requested changes Apr 21, 2022
View reviewed changes
@benediktibk benediktibk force-pushed the add_h7_lse_driving_cap branch 2 times, most recently from 3b3b7c9 to 68d9320 Compare April 21, 2022 07:49
@benediktibk benediktibk requested a review from erwango April 21, 2022 08:45
@benediktibk
drivers: clock_control: Make LSE driving configurable
66e112d 
Make the LSE driving capability configurable for the STM32 series.
Fixes zephyrproject-rtos#44737.

Signed-off-by: Benedikt Schmidt <[email protected]>
@benediktibk benediktibk force-pushed the add_h7_lse_driving_cap branch from 68d9320 to 66e112d Compare April 21, 2022 12:23
@benediktibk
Copy link
Contributor Author

benediktibk commented Apr 28, 2022

@erwango Anything still missing?

@carlescufi carlescufi merged commit 86469b1 into zephyrproject-rtos:main Apr 29, 2022
@benediktibk benediktibk deleted the add_h7_lse_driving_cap branch March 6, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwango erwango erwango approved these changes

@FRASTM FRASTM FRASTM approved these changes

@nashif nashif Awaiting requested review from nashif

@carlescufi carlescufi Awaiting requested review from carlescufi

@galak galak Awaiting requested review from galak

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@ABOSTM ABOSTM Awaiting requested review from ABOSTM

@gmarull gmarull Awaiting requested review from gmarull

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@jhedberg jhedberg Awaiting requested review from jhedberg

@Vudentz Vudentz Awaiting requested review from Vudentz

@mbolivar-nordic mbolivar-nordic Awaiting requested review from mbolivar-nordic

Assignees

@erwango erwango

Labels

area: API Changes to public APIs area: Boards area: Clock Control area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: Timer Timer platform: STM32 ST Micro STM32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Configurable LSE driving capability on H735

6 participants

@benediktibk @FRASTM @erwango @mbolivar-nordic @carlescufi @zephyrbot