Skip to content

Conversation

@JON95Git
Copy link

Using these PRs as example (#41981, #43965 and #44533)
Adding support for FMC (Flexible Memory Controller) as a prerequisite to add support for LTDC in the future.
An application using LVGL with frame buffer allocated in SDRAM was tested with no problems.

@JON95Git JON95Git force-pushed the stm32f746g_disco-fmc branch from 430a5dd to 22dbfc3 Compare April 16, 2022 00:10
@JON95Git JON95Git changed the title boards: arm: add support for fmc boards: arm: stm32f746g_disco: add support for fmc Apr 16, 2022
@zephyrbot zephyrbot requested a review from gmarull April 19, 2022 01:50
@JON95Git
Copy link
Author

Hi @erwango. Are there any steps I have to take before you can proceed with the review? Sorry for my ignorance, this is my first PR and I don't know what to do now.

@erwango
Copy link
Member

erwango commented Apr 25, 2022

Hi @erwango. Are there any steps I have to take before you can proceed with the review? Sorry for my ignorance, this is my first PR and I don't know what to do now.

I'm having a look. Thanks sharing this work.
Can you update your sign-off, in order to fixe CI reported issues?

Error: See https://docs.zephyrproject.org/latest/contribute/#commit-guidelines for more details

ccc2fae986cb9b1fce1d079e71dbdefa1131dc55: author email (JON95Git <[email protected]>) needs to match one of the signed-off-by entries.
ccc2fae986cb9b1fce1d079e71dbdefa1131dc55: author email (JON95Git <[email protected]>) does not follow the syntax: First Last <email>.

@JON95Git JON95Git force-pushed the stm32f746g_disco-fmc branch from 22dbfc3 to f421890 Compare April 25, 2022 14:48
@JON95Git
Copy link
Author

Hi @erwango. Are there any steps I have to take before you can proceed with the review? Sorry for my ignorance, this is my first PR and I don't know what to do now.

I'm having a look. Thanks sharing this work. Can you update your sign-off, in order to fixe CI reported issues?

Error: See https://docs.zephyrproject.org/latest/contribute/#commit-guidelines for more details

ccc2fae986cb9b1fce1d079e71dbdefa1131dc55: author email (JON95Git <[email protected]>) needs to match one of the signed-off-by entries.
ccc2fae986cb9b1fce1d079e71dbdefa1131dc55: author email (JON95Git <[email protected]>) does not follow the syntax: First Last <email>.

Done.

@JON95Git JON95Git force-pushed the stm32f746g_disco-fmc branch 2 times, most recently from ce49339 to e325454 Compare April 25, 2022 16:18
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please fix commit's author (cf https://www.git-tower.com/learn/git/faq/change-author-name-email).

Update board device tree with FMC node

Update board documentation - FMC pinout

Signed-off-by: Jonathan Gonzaga <[email protected]>
@JON95Git JON95Git force-pushed the stm32f746g_disco-fmc branch from e325454 to a9f4c40 Compare April 29, 2022 15:54
@JON95Git
Copy link
Author

Looks good, but please fix commit's author (cf https://www.git-tower.com/learn/git/faq/change-author-name-email).

Sorry. I had changed it before:

jonathan@jonathan-pc:~$ git config --list
[email protected]
user.name=Jonathan Gonzaga

I don't know why the changes weren't made.
In the last commit I used the --author flag explicitly.
Hope it works now.

@JON95Git JON95Git requested a review from erwango May 2, 2022 16:13
@erwango
Copy link
Member

erwango commented May 12, 2022

@JON95Git, I'm closing this PR as #45515 was merged recently and provide the same changes.

@erwango erwango closed this May 12, 2022
@JON95Git
Copy link
Author

@JON95Git, I'm closing this PR as #45515 was merged recently and provide the same changes.

Nice.

@JON95Git JON95Git deleted the stm32f746g_disco-fmc branch May 12, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants