drivers: can: mcan: refactor to get rid of wrapper functions #44951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Devicetree
platform: NXP
henrikbrixandersen
force-pushed
the
can_mcan_refactoring
branch
4 times, most recently
from
5fb8217 to
15ae8f2
Compare
Rename the private header file for the Bosch M_CAN shared driver code from can_mcan_int.h to can_mcan_priv.h to follow the common naming scheme. Signed-off-by: Henrik Brix Andersen <[email protected]>
Refactor the Bosch M_CAN shared driver functions to get rid of the front-end driver wrapper functions. This requires flipping the relationship between shared config/data structs and front-end config/data structs. Front-end drivers can now store a pointer to their custom config/data structs in the .custom fields of the can_mcan_config and can_mcan_data data structures. Signed-off-by: Henrik Brix Andersen <[email protected]>
henrikbrixandersen
force-pushed
the
can_mcan_refactoring
branch
from
15ae8f2 to
ca4bd58
Compare
henrikbrixandersen
requested review from
alexanderwachter,
dleach02 and
mmahadevan108
as code owners
henrikbrixandersen
requested review from
alexanderwachter,
erwango,
karstenkoenig,
martinjaeger and
nandojve
and removed request for
alexanderwachter,
dleach02 and
mmahadevan108
henrikbrixandersen
added
the
platform: Microchip SAM
Member
Author
|
There are no functional changes in this PR, only refactoring to get rid of the wrapper functions. Reviews are most welcome. |
gmarull
reviewed
Apr 28, 2022
drivers/can/can_mcux_mcan.c
Outdated
Comment on lines
133
to
134
Member
There was a problem hiding this comment.
maybe provide DT based macros to avoid usage of DT_DRV_INST, maybe to define as well, e.g.
CAN_MCAN_CONFIG_DT_INST_DEFINE(n, &mcux_can_config_##n);
Member
Author
There was a problem hiding this comment.
Good idea. I had initially added inst variants as the only variants, but decided to go for a more generic node_id approach. I have added both now and (re-)named them to reflect the DT part.
Add shared initializer macros for struct can_mcan_config and struct can_mcan_data. Signed-off-by: Henrik Brix Andersen <[email protected]>
henrikbrixandersen
force-pushed
the
can_mcan_refactoring
branch
from
ca4bd58 to
d76e1de
Compare
Member
Author
|
@alexanderwachter, @martinjaeger et al: please take a look. |
martinjaeger
approved these changes
May 1, 2022
dkalowsk
approved these changes
May 2, 2022
stephanosio
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the Bosch M_CAN shared driver functions to get rid of the front-end driver wrapper functions.
This requires flipping the relationship between shared config/data structs and front-end config/data structs. Front-end drivers can now store a pointer to their custom config/data structs in the .custom fields of the
can_mcan_configandcan_mcan_datadata structures.Rename the private header file for the Bosch M_CAN shared driver code from
can_mcan_int.htocan_mcan_priv.hto follow the common naming scheme.Add shared initializer macros for
struct can_mcan_configandstruct can_mcan_data.The changes were tested on hardware for the following drivers:
The changes were only compile-tested for the following drivers due to lack of hardware. Additional testing most welcome.