Add support arduino portenta h7 #45221

benjaminbjornsson · 2022-04-28T19:14:40Z

No description provided.

erwango

Thanks for this work.
This looks globally fine, but some clean up required

boards/arm/arduino_portenta_h7/arduino_portenta_h7-common.dtsi

boards/arm/arduino_portenta_h7/board.c

boards/arm/arduino_portenta_h7/Kconfig.board

boards/arm/arduino_portenta_h7/Kconfig.defconfig

boards/arm/arduino_portenta_h7/arduino_portenta_h7-common.dtsi

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m7.dts

boards/arm/arduino_portenta_h7/doc/index.rst

boards/arm/arduino_portenta_h7/Kconfig.defconfig

romainreignier · 2022-05-02T17:33:01Z

Thnaks @benjaminbjornsson for this work!
I have started to do the same last month, but because I am new to Zephyr, the path was a bit difficult for me.

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m7.dts

boards/arm/arduino_portenta_h7/arduino_portenta_h7-common.dtsi

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m7.yaml

romainreignier · 2022-05-03T05:31:32Z

dts/arm/st/h7/stm32h7.dtsi

Maybe the definition in [stm32h743.dtsi](https://github.com/zephyrproject-rtos/zephyr/blob/7fe5ab315a4453322780e5655364fe4de2a1b9b6/dts/arm/st/h7/stm32h743.dtsi) should be removed then?

zephyr/dts/arm/st/h7/stm32h743.dtsi

Lines 22 to 34 in 7fe5ab3

usbotg_fs: usb@40080000 {

compatible = "st,stm32-otgfs";

reg = <0x40080000 0x40000>;

interrupts = <101 0>, <98 0>, <99 0>;

interrupt-names = "otgfs", "ep1_out", "ep1_in";

num-bidir-endpoints = <9>;

ram-size = <4096>;

maximum-speed = "full-speed";

clocks = <&rcc STM32_CLOCK_BUS_AHB1 0x080000000>;

phys = <&otghs_fs_phy>;

status = "disabled";

label= "OTG_FS";

};

I have noticed that the interrupts are not in the same order and h743 version has only 3 interrupts.

@romainreignier Thanks for raising this.
Actually this change is not correct. Only stm32H742 "and higher" support usbotg_fs. On the other hand usbotg_hs is indeed supported on the whole stm32h7 series.

Great catch! I'll move it to stm32h745.dtsi

I am still unable to use the sample samples/subsys/usb/console on the MachineControl, the USB device is not detected by the kernel on boot.

boards/arm/arduino_portenta_h7/arduino_portenta_h7-common.dtsi

romainreignier · 2022-05-03T18:17:03Z

I have tried your branch myself and managed to run some samples:

basic/blinky on M7
basic/blinky on M4
hello_world on M7
subsys/console/echo on M7
subsys/shell/shell_module on M7
drivers/adc on M7

For the adc sample, I had to add these lines to the common dtsi:

&adc1 {
	pinctrl-0 = <&adc1_inp0_pa0>;
	pinctrl-names = "default";
	status = "okay";
};

And this overlay in the sample:

/ {
	zephyr,user {
		io-channels = <&adc1 0>;
	};
};

I don't own the Breakout Board to try the USB FS but I have a MachineControl on which I might test it.
I also have the Ethernet Vision shield on which I plan to test the Ethernet.

Everything went well 👍

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m4.yaml

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m7.yaml

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m7_defconfig

boards/arm/arduino_portenta_h7/board.c

erwango

Few last comment on my side.

Also, can you comment on the core frequency question ?

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m7_defconfig

github-actions · 2022-07-18T00:30:31Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

dt updates made, lgtm

erwango · 2022-08-08T06:31:19Z

@benjaminbjornsson can you check the build issues reported by CI ?

benjaminbjornsson · 2022-08-08T18:35:38Z

@benjaminbjornsson can you check the build issues reported by CI ?

@erwango I'm confused, it's not the board being added that fails now. Should more boards be excluded from flash_shell or did I break something by adding the new board to the exclude list?

erwango · 2022-08-10T06:47:40Z

@benjaminbjornsson can you check the build issues reported by CI ?

@erwango I'm confused, it's not the board being added that fails now. Should more boards be excluded from flash_shell or did I break something by adding the new board to the exclude list?

ok, please rebase and force push

erwango · 2022-08-11T08:27:59Z

@benjaminbjornsson It seems that you're out of luck and hit be several issues non related with your commit.
2 of them were unknown till now, and I raised dedicated issues (see #48911 and #48912).
Other one is known (#48608) but seems to be a tricky one.

Meanwhile, can you check following remaning comment: #45221 (comment) ?

romainreignier · 2022-09-12T12:14:45Z

It seems that the only remaining issue is the line about the user button in the description text file.
It should not take too much time to remove @benjaminbjornsson
Thank you.

erwango · 2022-09-12T13:10:43Z

It seems that the only remaining issue is the line about the user button in the description text file. It should not take too much time to remove @benjaminbjornsson Thank you.

PR also requires a rebase.
Note that we're now in the process of releasing V3.2.0 and PR that are not bug fixes will now have to wait that the V3.2.0 is fully released before being merged.

This has been verified running samples usb/console and usb/cdc_acm on a STM32H747XIH. Signed-off-by: Benjamin Björnsson <[email protected]>

This commit adds support for the Arduino Portenta H7 board. The board functionallity has been verified by running following samples: - hello_world on m7 core - usb/console on m7 core - blinky on m4 core Signed-off-by: Benjamin Björnsson <[email protected]>

Exclude Arduino Portenta H7 because the flash driver isn't supported yet on the M4 core. Signed-off-by: Benjamin Björnsson <[email protected]>

benjaminbjornsson · 2022-10-04T14:24:47Z

Sorry for the delay, I've removed the line about the push-button in the index now and also rebased.

benjaminbjornsson requested review from MaureenHelm, erwango, galak and nashif as code owners April 28, 2022 19:14

github-actions bot added area: Boards area: Devicetree area: Documentation platform: STM32 ST Micro STM32 labels Apr 28, 2022

benjaminbjornsson force-pushed the add_support_arduino_portenta_h7 branch from 61053c0 to 2fc928b Compare April 28, 2022 19:45

erwango requested changes Apr 29, 2022

View reviewed changes

zephyrbot requested review from ABOSTM, FRASTM and gmarull April 29, 2022 15:37

benjaminbjornsson force-pushed the add_support_arduino_portenta_h7 branch 2 times, most recently from 8e3e960 to c53b7a1 Compare April 30, 2022 16:09

romainreignier reviewed May 2, 2022

View reviewed changes

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m7.dts Outdated Show resolved Hide resolved

romainreignier reviewed May 2, 2022

View reviewed changes

boards/arm/arduino_portenta_h7/arduino_portenta_h7-common.dtsi Outdated Show resolved Hide resolved

romainreignier reviewed May 2, 2022

View reviewed changes

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m7.yaml Outdated Show resolved Hide resolved

romainreignier reviewed May 3, 2022

View reviewed changes

boards/arm/arduino_portenta_h7/arduino_portenta_h7-common.dtsi Outdated Show resolved Hide resolved

erwango requested changes May 4, 2022

View reviewed changes

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m4.yaml Outdated Show resolved Hide resolved

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m7.yaml Outdated Show resolved Hide resolved

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m7_defconfig Outdated Show resolved Hide resolved

erwango requested changes May 6, 2022

View reviewed changes

boards/arm/arduino_portenta_h7/board.c Outdated Show resolved Hide resolved

benjaminbjornsson force-pushed the add_support_arduino_portenta_h7 branch 2 times, most recently from 1dd91c1 to dc258c8 Compare May 14, 2022 09:23

erwango added this to the v3.2.0 milestone May 17, 2022

erwango requested changes May 17, 2022

View reviewed changes

boards/arm/arduino_portenta_h7/arduino_portenta_h7_m7_defconfig Outdated Show resolved Hide resolved

github-actions bot added the Stale label Jul 18, 2022

zephyrbot requested a review from GeorgeCGV August 7, 2022 12:18

benjaminbjornsson force-pushed the add_support_arduino_portenta_h7 branch from 59a6c68 to a9e6818 Compare August 8, 2022 16:08

zephyrbot added the area: Flash label Aug 8, 2022

zephyrbot requested a review from nvlsianpu August 8, 2022 16:09

benjaminbjornsson force-pushed the add_support_arduino_portenta_h7 branch from a9e6818 to 2800451 Compare August 10, 2022 15:12

This was referenced Aug 11, 2022

sample.drivers.flash.shell: Failed on atmel targets #48911

Closed

sample.drivers.flash.shell: Failed on NXP targets #48912

Closed

erwango self-requested a review August 11, 2022 08:24

nvlsianpu removed their request for review August 12, 2022 12:14

erwango modified the milestones: v3.2.0, v3.3.0 Sep 12, 2022

benjaminbjornsson added 3 commits October 4, 2022 16:16

dts: stm32h7: Add OTG FS to DTS of the STM32H7 series

680e713

This has been verified running samples usb/console and usb/cdc_acm on a STM32H747XIH. Signed-off-by: Benjamin Björnsson <[email protected]>

samples: flash_shell: Add board to platform_exclude list

b82656f

Exclude Arduino Portenta H7 because the flash driver isn't supported yet on the M4 core. Signed-off-by: Benjamin Björnsson <[email protected]>

benjaminbjornsson force-pushed the add_support_arduino_portenta_h7 branch from 2800451 to b82656f Compare October 4, 2022 14:23

zephyrbot requested a review from nvlsianpu October 4, 2022 14:24

erwango approved these changes Oct 4, 2022

View reviewed changes

FRASTM approved these changes Oct 6, 2022

View reviewed changes

erwango requested a review from fabiobaltieri October 6, 2022 15:08

MaureenHelm merged commit 2ba91ce into zephyrproject-rtos:main Oct 6, 2022

benjaminbjornsson deleted the add_support_arduino_portenta_h7 branch November 13, 2022 15:26

bdunlay mentioned this pull request Jun 12, 2023

Arduino Portenta H7 #59174

Closed

	usbotg_fs: usb@40080000 {
	compatible = "st,stm32-otgfs";
	reg = <0x40080000 0x40000>;
	interrupts = <101 0>, <98 0>, <99 0>;
	interrupt-names = "otgfs", "ep1_out", "ep1_in";
	num-bidir-endpoints = <9>;
	ram-size = <4096>;
	maximum-speed = "full-speed";
	clocks = <&rcc STM32_CLOCK_BUS_AHB1 0x080000000>;
	phys = <&otghs_fs_phy>;
	status = "disabled";
	label= "OTG_FS";
	};

Add support arduino portenta h7 #45221

Add support arduino portenta h7 #45221

Conversation

benjaminbjornsson commented Apr 28, 2022

Uh oh!

erwango left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

romainreignier commented May 2, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

romainreignier May 3, 2022

Choose a reason for hiding this comment

Uh oh!

erwango May 4, 2022

Choose a reason for hiding this comment

Uh oh!

benjaminbjornsson May 13, 2022

Choose a reason for hiding this comment

Uh oh!

romainreignier May 17, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romainreignier commented May 3, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erwango left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 18, 2022

Uh oh!

erwango commented Aug 8, 2022

Uh oh!

benjaminbjornsson commented Aug 8, 2022

Uh oh!

erwango commented Aug 10, 2022

Uh oh!

erwango commented Aug 11, 2022

Uh oh!

romainreignier commented Sep 12, 2022

Uh oh!

erwango commented Sep 12, 2022

Uh oh!

benjaminbjornsson commented Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants