ARC: boards: HSDK: get rid of pinmux usage #45343

evgeniy-paltsev · 2022-05-04T13:53:38Z

Pinmux is deprecated (see #39740) so let's get rid of it's usage for HSDK board.

As we call pinmux only once at init phase we simply do register setup in platform code instead of pinctrl.

gmarull

Where is the pinctrl driver?

evgeniy-paltsev · 2022-05-04T19:57:58Z

Where is the pinctrl driver?

We don't need it - we used to use pinmux driver just to unconditionally set one SoC-specific register once during boot. But it's excessive to use pinmux / pinctrl for that. So we simply set this register from platform code and drop old pinmux driver.

gmarull · 2022-05-05T08:05:00Z

Hi @gmarull

Where is the pinctrl driver?

We don't need it - we used to use pinmux driver just to unconditionally set one SoC-specific register once during boot. But it's excessive to use pinmux / pinctrl for that. So we simply set this register from platform code and drop old pinmux driver.

To my understanding current pinmux driver allows to set alt funcs, it's not "one Soc-specific register",

zephyr/drivers/pinmux/pinmux_hsdk.c

Lines 21 to 34 in dfc4c3f

    
           static int pinmux_hsdk_set(const struct device *dev, uint32_t pin, 
        
           			   uint32_t func) 
        
           { 
        
           	if (func >= HSDK_PINMUX_FUNS || pin >= HSDK_PINMUX_SELS) 
        
           		return -EINVAL; 
        
           	creg_gpio_mux_reg &= ~(0x07U << (pin * 3)); 
        
           	creg_gpio_mux_reg |= (func << (pin * 3)); 
        
           	_arc_sync(); 
        
           	return 0; 
        
           }

zephyr/boards/arc/hsdk/pinmux.c

Lines 19 to 30 in dfc4c3f

    
           	/* 
        
           	 * to do configuration for each sel, 
        
           	 * please refer the doc for hsdk board. 
        
           	 */ 
        
           	pinmux_pin_set(pinmux, HSDK_PINMUX_SEL0, HSDK_PINMUX_FUN0); 
        
           	pinmux_pin_set(pinmux, HSDK_PINMUX_SEL1, HSDK_PINMUX_FUN0); 
        
           	pinmux_pin_set(pinmux, HSDK_PINMUX_SEL2, HSDK_PINMUX_FUN0); 
        
           	pinmux_pin_set(pinmux, HSDK_PINMUX_SEL3, HSDK_PINMUX_FUN2); 
        
           	pinmux_pin_set(pinmux, HSDK_PINMUX_SEL4, HSDK_PINMUX_FUN0); 
        
           	pinmux_pin_set(pinmux, HSDK_PINMUX_SEL5, HSDK_PINMUX_FUN0); 
        
           	pinmux_pin_set(pinmux, HSDK_PINMUX_SEL6, HSDK_PINMUX_FUN0); 
        
           	pinmux_pin_set(pinmux, HSDK_PINMUX_SEL7, HSDK_PINMUX_FUN0);

This functionality is now removed. Note that it is not acceptable anymore to do this sort of configuration at board level using custom C code.

ruuddw · 2022-05-05T10:39:18Z

The more advanced pinmux functionality isn't required/used by 'normal' applications, so this was the simpler solution. Evgeniy, maybe create an enhancement issue to add pinmux functionality for HSDK in the future using the new pinmux solution?

gmarull · 2022-05-05T10:42:04Z

The more advanced pinmux functionality isn't required/used by 'normal' applications,

what are 'normal' applications?

Does that mean boards using this SoC are always forced to route signals to the same set of pins?

codecov-commenter · 2022-05-05T13:28:41Z

Codecov Report

Merging #45343 (dfc4c3f) into main (7c641e9) will decrease coverage by 0.01%.
The diff coverage is 49.60%.

❗ Current head dfc4c3f differs from pull request most recent head c941d86. Consider uploading reports for the commit c941d86 to get more accurate results

@@            Coverage Diff             @@
##             main   #45343      +/-   ##
==========================================
- Coverage   49.89%   49.88%   -0.02%     
==========================================
  Files         643      643              
  Lines       80626    80677      +51     
  Branches    18933    18952      +19     
==========================================
+ Hits        40230    40246      +16     
- Misses      33733    33763      +30     
- Partials     6663     6668       +5

Impacted Files	Coverage Δ
drivers/counter/counter_cmos.c	`82.97% <ø> (ø)`
include/zephyr/bluetooth/gatt.h	`100.00% <ø> (ø)`
include/zephyr/drivers/adc.h	`93.33% <ø> (ø)`
kernel/sched.c	`88.71% <ø> (ø)`
subsys/bluetooth/host/att.c	`0.00% <ø> (ø)`
subsys/bluetooth/host/gatt.c	`8.56% <0.00%> (ø)`
subsys/net/lib/lwm2m/lwm2m_engine.c	`10.85% <0.00%> (-0.04%)`	⬇️
subsys/net/lib/lwm2m/lwm2m_rd_client.c	`1.98% <7.14%> (+0.35%)`	⬆️
kernel/timer.c	`86.40% <50.00%> (-0.73%)`	⬇️
subsys/net/lib/lwm2m/lwm2m_obj_server.c	`51.28% <50.00%> (ø)`
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c641e9...c941d86. Read the comment docs.

evgeniy-paltsev · 2022-05-09T11:28:03Z

Rebase to fix conflicts. @abrodkin @ruuddw - please approve again.

evgeniy-paltsev · 2022-05-09T11:30:42Z

Does that mean boards using this SoC are always forced to route signals to the same set of pins?

Currently we don't support other configurations, so yes.

Pinmux is deprecated (see zephyrproject-rtos#39740) so let's get rid of it's usage for HSDK board. As we call pinmux only once at init phase we simply do register setup in platform code instead of pinmux. Signed-off-by: Evgeniy Paltsev <[email protected]> Signed-off-by: Eugeniy Paltsev <[email protected]>

Pinmux is depricated (see zephyrproject-rtos#39740) and shouldn't be used anymore Signed-off-by: Evgeniy Paltsev <[email protected]> Signed-off-by: Eugeniy Paltsev <[email protected]>

evgeniy-paltsev · 2022-05-10T13:53:28Z

Rebase to fix merge conflicts. @abrodkin @ruuddw - please approve again.

evgeniy-paltsev · 2022-05-10T15:47:18Z

Hi @gmarull
I am wondering if you stilll have any objections or we can merge this?

Thanks!

evgeniy-paltsev · 2022-05-12T21:40:39Z

If there is no disagreement anymore, let's merge this.

henrikbrixandersen

I think this is acceptable for now, but a proper pinctrl driver should be added going forward. Please open a enhancement request issue for this when merged.

no pinctrl code to be reviewed

github-actions bot added area: Boards area: Devicetree area: Devicetree Binding PR modifies or adds a Device Tree binding labels May 4, 2022

evgeniy-paltsev mentioned this pull request May 4, 2022

Road from pinmux to pinctrl #39740

Closed

29 tasks

evgeniy-paltsev added the area: ARC ARC Architecture label May 4, 2022

evgeniy-paltsev marked this pull request as ready for review May 4, 2022 14:05

evgeniy-paltsev requested review from abrodkin, galak and ruuddw as code owners May 4, 2022 14:06

evgeniy-paltsev added the platform: Synopsys Synopsys label May 4, 2022

zephyrbot added the area: Pinmux label May 4, 2022

zephyrbot requested review from gmarull, mbolivar-nordic and mnkp May 4, 2022 19:02

zephyrbot assigned ruuddw May 4, 2022

gmarull previously requested changes May 4, 2022

View reviewed changes

evgeniy-paltsev requested a review from gmarull May 4, 2022 19:58

ruuddw previously approved these changes May 5, 2022

View reviewed changes

abrodkin previously approved these changes May 5, 2022

View reviewed changes

evgeniy-paltsev dismissed stale reviews from abrodkin and ruuddw via acb6374 May 9, 2022 11:26

evgeniy-paltsev force-pushed the rff-hsdk-pinmux-remove-v0 branch from c941d86 to acb6374 Compare May 9, 2022 11:26

evgeniy-paltsev requested a review from abrodkin May 9, 2022 11:30

evgeniy-paltsev requested a review from ruuddw May 9, 2022 11:30

ruuddw previously approved these changes May 9, 2022

View reviewed changes

abrodkin previously approved these changes May 9, 2022

View reviewed changes

evgeniy-paltsev added 2 commits May 10, 2022 17:50

ARC: HSDK: remove pinmux_hsdk driver

b08e559

Pinmux is depricated (see zephyrproject-rtos#39740) and shouldn't be used anymore Signed-off-by: Evgeniy Paltsev <[email protected]> Signed-off-by: Eugeniy Paltsev <[email protected]>

evgeniy-paltsev dismissed stale reviews from abrodkin and ruuddw via b08e559 May 10, 2022 13:53

evgeniy-paltsev force-pushed the rff-hsdk-pinmux-remove-v0 branch from acb6374 to b08e559 Compare May 10, 2022 13:53

evgeniy-paltsev requested review from abrodkin and ruuddw May 10, 2022 13:53

ruuddw approved these changes May 10, 2022

View reviewed changes

abrodkin approved these changes May 10, 2022

View reviewed changes

evgeniy-paltsev added this to the v3.1.0 milestone May 12, 2022

henrikbrixandersen approved these changes May 18, 2022

View reviewed changes

carlescufi approved these changes May 18, 2022

View reviewed changes

carlescufi changed the title ~~ARC: boards: HSDK: ged rid of pinmux usage~~ ARC: boards: HSDK: get rid of pinmux usage May 18, 2022

carlescufi merged commit 3b0517b into zephyrproject-rtos:main May 18, 2022

ARC: boards: HSDK: get rid of pinmux usage #45343

ARC: boards: HSDK: get rid of pinmux usage #45343

Uh oh!

Conversation

evgeniy-paltsev commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

evgeniy-paltsev commented May 4, 2022

Uh oh!

gmarull commented May 5, 2022

Uh oh!

ruuddw commented May 5, 2022

Uh oh!

gmarull commented May 5, 2022

Uh oh!

codecov-commenter commented May 5, 2022

Codecov Report

Uh oh!

evgeniy-paltsev commented May 9, 2022

Uh oh!

evgeniy-paltsev commented May 9, 2022

Uh oh!

evgeniy-paltsev commented May 10, 2022

Uh oh!

evgeniy-paltsev commented May 10, 2022

Uh oh!

evgeniy-paltsev commented May 12, 2022

Uh oh!

henrikbrixandersen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

evgeniy-paltsev commented May 4, 2022 •

edited

Loading