Skip to content

drivers/serial: stm32: Enable UART alternate clocks #45508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2022
Merged

drivers/serial: stm32: Enable UART alternate clocks #45508

merged 1 commit into from
May 11, 2022

Conversation

@r2r0
Copy link
Member

@r2r0 r2r0 commented May 10, 2022 •
edited
Loading

This PR allows STM32 UART device drivers to use alternate clocks introduced by #45053.
Example board (STM32WB55 based) configuration to enable HSI clock on LPUART:

&clk_hsi{
    status = "okay";
};

&lpuart1 {
    current-speed = <115200>;
    /delete-property/ clocks;
    clocks = <&rcc STM32_CLOCK_BUS_APB1_2 0x00000001>, <&rcc STM32_SRC_HSI LPUART1_SEL(2)>;
    wakeup-source;
    status = "okay";
};

Based on: #45053

@erwango
Copy link
Member

erwango commented May 10, 2022

@r2r0 would you mind rebasing, now that #45053 got merged ?

@r2r0
Copy link
Member Author

r2r0 commented May 11, 2022

@erwango Rebase done.

GeorgeCGV
GeorgeCGV reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@GeorgeCGV GeorgeCGV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
only minor corrections that would be great to have

erwango
erwango approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution.
Nit: I tend to prefer titles that are a bit more specific:
drivers/serial: stm32: bla or drivers: serial: stm32: bla

erwango
erwango requested changes May 11, 2022
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late couple of nit fixes.

@r2r0 r2r0 changed the title stm32: Enable UART alternate clocks drivers/serial: stm32: Enable UART alternate clocks May 11, 2022
@r2r0
stm32: Allow UARTs to use alternate clocks.
c21bd35 
Add support for an alternate clock. If available,
alternate clock is enabled and used to get the
device clock rate.
Based on: #45053.

Signed-off-by: Artur Lipowski <[email protected]>
@MaureenHelm MaureenHelm merged commit bb85759 into zephyrproject-rtos:main May 11, 2022
@r2r0 r2r0 deleted the stm32uart_alternate_clocks branch May 12, 2022 05:53
@mrfuchs mrfuchs mentioned this pull request Jun 16, 2022
Closed
@erwango erwango mentioned this pull request Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeorgeCGV GeorgeCGV GeorgeCGV approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@erwango erwango erwango approved these changes

@FRASTM FRASTM FRASTM approved these changes

@nashif nashif Awaiting requested review from nashif

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@carlescufi carlescufi Awaiting requested review from carlescufi

@galak galak Awaiting requested review from galak

@ABOSTM ABOSTM Awaiting requested review from ABOSTM

Assignees

@erwango erwango

Labels

area: Boards area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: Documentation area: SPI SPI bus platform: STM32 ST Micro STM32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@r2r0 @erwango @GeorgeCGV @MaureenHelm @FRASTM