ARC: boards: nsim: hs5x/hs6x: setup apertures to be runnable on HAPS #45605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrodkin
previously approved these changes
May 13, 2022
ruuddw
previously approved these changes
May 13, 2022
Member
ruuddw
left a comment
ruuddw
left a comment
There was a problem hiding this comment.
Minor style suggestions.
Board-level initialization is fine I think, things like 'sram size' (external memory in this case, I assume) is board specific.
A more general approach would be to have 'drivers' (couldn't the ARC_CONNECT programming be done with the current driver for that?) for the controls and initialize/configure them all from dts entries.
Setup peripheral and NOC apertures to make hs5x and hs6x configurations runnable on real HW (HAPS). Signed-off-by: Evgeniy Paltsev <[email protected]> Signed-off-by: Eugeniy Paltsev <[email protected]>
evgeniy-paltsev
force-pushed
the
rff-haps-nsim-arcv3-apert-setup-v0
branch
from
196fc8d to
b576680
Compare
abrodkin
approved these changes
May 13, 2022
ruuddw
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup peripheral and NOC apertures to make hs5x and hs6x configurations (both UP and SMP) runnable on real HW (HAPS).
PS: later we can try to implement it in a more generic way, though I'm not fully sure what is the best way to do that, as such setup is quite SoC-specific. Till then let's keep it in nsim* board platform code.