Trivial fixes #45608
Merged
Trivial fixes #45608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-packard
requested review from
andyross,
dcpleung,
de-nordic,
nashif and
tbursztyka
as code owners
github-actions
bot
added
area: Kernel
area: Samples
gmarull
reviewed
May 13, 2022
stephanosio
reviewed
May 13, 2022
zephyrbot
added
area: SPI
zephyrbot
requested review from
KangJianX,
ceolin,
enjiamai,
nordicjm and
peter-mitsis
keith-packard
force-pushed
the
trivial-fixes
branch
from
0846bcb to
70265c0
Compare
keith-packard
force-pushed
the
trivial-fixes
branch
from
70265c0 to
fe7aa94
Compare
de-nordic
previously approved these changes
May 13, 2022
Contributor
de-nordic
left a comment
de-nordic
left a comment
There was a problem hiding this comment.
mgmt/mcumgr/lib subsystem looks OK.
andyross
previously approved these changes
May 13, 2022
Contributor
andyross
left a comment
andyross
left a comment
There was a problem hiding this comment.
A digression about one of the fixes, but everything looks fine to me.
dcpleung
previously approved these changes
May 13, 2022
keith-packard
dismissed stale reviews from dcpleung, andyross, and de-nordic
via
e317a20
nordicjm
previously approved these changes
May 18, 2022
Contributor
nordicjm
left a comment
nordicjm
left a comment
There was a problem hiding this comment.
mcumgr changes approved
ceolin
previously approved these changes
May 19, 2022
stephanosio
previously approved these changes
May 19, 2022
Somehow two files in subsys/mgmt/mcumgr/lib/cmd/img_mgmt/src ended up using STRINGIFY but nothing in their include path ended up pulling in zephyr/toolchain/common.h. Include that via zephyr/toolchain.h. v2: Use non-internal zephyr/toolchain.h header Signed-off-by: Keith Packard <[email protected]>
The initialized test buffers tx_data and tx2_data were not given a specific size, but were initialized with one more byte than the uninitialized buffers they get copied to. As a result, the memcpy found a buffer overflow. Fix this by setting the source buffer sizes to match the destination. Signed-off-by: Keith Packard <[email protected]>
This ensures that we have a definition of z_errno in case that isn't pulled in with errno.h Signed-off-by: Keith Packard <[email protected]>
We need to keep gcc from complaining about large calloc/malloc/realloc sizes as that's what we're testing. Define _BSD_SOURCE so that libraries sharing the glibc convention (like newlib and picolibc) for controlling the API level visible to applications will declare reallocarray(3), which is an OpenBSD extension to the C library. Signed-off-by: Keith Packard <[email protected]>
qsort_r is a GNU addition, so we need to #define _GNU_SOURCE to ensure the prototype is defined in the header file. Signed-off-by: Keith Packard <[email protected]>
off_t is often unsigned long, which means printf needs to use %lx. Insert a cast in case the value is unsigned int. Signed-off-by: Keith Packard <[email protected]>
mbolivar-nordic
force-pushed
the
trivial-fixes
branch
from
e317a20 to
8b128d7
Compare
Contributor
|
Rebased in the GitHub UI to try to get clean CI without removing all the +1s |
mbolivar-nordic
dismissed stale reviews from andyross, stephanosio, ceolin, de-nordic, and nordicjm
via
8b128d7
stephanosio
approved these changes
May 27, 2022
mbolivar-nordic
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a selection of trivial fixes, mostly in sample and test code, that clean up some improper API usage and make the code more compatible with the C standard library. The only change in the core OS is in the img_mgmt subsystem to add
an additional header reference.