Bluetooth: controller: llcp: fix for send correct collision code #45681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruithofa
requested review from
carlescufi,
cvinayak,
ppryga-nordic and
thoh-ot
as code owners
github-actions
bot
added
area: Bluetooth
area: Bluetooth Controller
area: Tests
Upon collision either the error code for different procedure collision or same procedure collision must be transmitted, which is fixed in this PR. Previously always the error code for same procedure collision was sent Signed-off-by: Andries Kruithof <[email protected]>
erbr-ot
approved these changes
May 16, 2022
Contributor
erbr-ot
left a comment
erbr-ot
left a comment
There was a problem hiding this comment.
Passed run on EBQ at our end for the tests in question
kruithofa
changed the title
kruithofa
changed the title
cvinayak
approved these changes
May 19, 2022
Author
Tests in question were run on EBQ at Nordic, and passed |
carlescufi
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon collision either the error code for different procedure
collision or same procedure collision must be transmitted,
which is fixed in this PR. Previously always the error code
for same procedure collision was sent
This will fix the collision related EBQ failures from issue #43435
Signed-off-by: Andries Kruithof [email protected]