fix ring_buf designated initializer order for RING_BUF_DECLARE #45698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottojo
requested review from
MaureenHelm,
carlescufi,
galak and
nashif
as code owners
stephanosio
requested changes
May 16, 2022
Member
stephanosio
left a comment
stephanosio
left a comment
There was a problem hiding this comment.
Thanks for submitting this PR.
Please review the Contribution Guidelines.
stephanosio
requested changes
May 16, 2022
Member
stephanosio
left a comment
stephanosio
left a comment
There was a problem hiding this comment.
1: UC3 Title does not follow [subsystem]: [subject] (and should not start with literal subsys:): "fix ring_buf designated initializer order for RING_BUF_DECLARE"
1: UC6 Body has no content, should at least have 1 line.
Please review https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines.
ottojo
force-pushed
the
ringbuf-fix
branch
2 times, most recently
from
480c17a to
472dc2d
Compare
Change order of designated initializers for ring_buf struct in the RING_BUF_DECLARE macro, to match the order in the struct definition. This fixes compilation when using C++, which requires using the same order as in the struct definition. Fixes zephyrproject-rtos#45697 Signed-off-by: Jonas Otto <[email protected]>
nordic-krch
approved these changes
May 18, 2022
npitre
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #45697