Bluetooth: Controller: df: CTE req not disabled if run in single shot #45726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an error. CTE request control procedure can be run in single shot or periodic mode. In case of run in single show, it is not disabled after completion. The code responsible for the disable was deleted by commit: ac7d050. The cte_req.is_enabled should be set to zero if the CTE request completes and cte_req.req_interval is zero. Signed-off-by: Piotr Pryga <[email protected]>
ppryga-nordic
requested review from
carlescufi,
cvinayak,
kruithofa and
thoh-ot
as code owners
thoh-ot
approved these changes
May 18, 2022
kruithofa
approved these changes
May 19, 2022
ppryga-nordic
deleted the
github-ble-df-fix-not-disabled-cte-req-when-run-single-shot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error. CTE request control procedure can be run in single
shot or periodic mode. In case of run in single show, it is not
disabled after completion.
The code responsible for the disable was deleted by commit:
ac7d050.
The cte_req.is_enabled should be set to zero if the CTE request
completes and cte_req.req_interval is zero.
Fixes: #45725
Signed-off-by: Piotr Pryga [email protected]