alternate clock configuration for the stm32 ospi driver #46703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRASTM
requested review from
MaureenHelm,
galak,
nashif and
nvlsianpu
as code owners
erwango
requested changes
Jun 20, 2022
FRASTM
force-pushed
the
ospi_clk_srce
branch
2 times, most recently
from
1b4d3db to
5ece992
Compare
Contributor
Author
|
refine with the new STM32_DT_CLOCKS macro from #46842 |
The clock of the octospi peripheral is directly defined by the DTS and configured by the clock_control_on function. No specific stm32cube function is required then. The clock control is taking this clock source to calculate the clock rate. Signed-off-by: Francois Ramu <[email protected]>
Contributor
Author
|
rebase after merge of #46842 |
erwango
requested changes
Jun 28, 2022
Member
erwango
left a comment
erwango
left a comment
There was a problem hiding this comment.
One request on the setting location, otherwise LGTM.
The definition of the clock source for the 2 octospi instances is given by the DTS node. The default value selects the sysclk (not pclk) for the alternate clock control. Signed-off-by: Francois Ramu <[email protected]>
The definition of the octospi clock source is given by the DTS node. The default value selects the sysclk (not pclk) for the alternate clock control. Signed-off-by: Francois Ramu <[email protected]>
Contributor
Author
|
By default, the alternate clock source for the octospi peripheral is not the PCLK but the SYSCLOCK, so it has to be defined in the DTS (of the soc). |
erwango
approved these changes
Jun 28, 2022
carlescufi
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For stm32 MCUs, this PR is configuring the clock source for the ospi peripheral based on the definition of the DTS.
The clock source of the Octospi is set by a bit field in one independent clock configuration register of the RCC.
In the clock control driver, the alternate clock source of the peripheral is defined by the macro OCTOSPI_SEL() or OSPI_SEL() depending on the serie. This is valid for any stm32 device with octospi peripheral.
The DTS of the board gives the clock source to be applied like:
Signed-off-by: Francois Ramu [email protected]