drivers: dma: Add GD32 DMA driver

[soburi]

Add support for GD32 DMA

Signed-off-by: TOKITA Hiroshi [email protected]

I verified ths PR with tests/drivers/dma/loop_transfer with GD32VF103(longan_nano board).

[nandojve]

Let's keep at 80 col

[soburi]

Currently, the clang-format setting is up to 100 columns(3f0e8dd).
Is this no good?

This code is formating with clang-format following instruction https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format.

[nandojve]

Hi @soburi ,

There was an agreement to allow up to 100 col in code. This doesn't mean that we will follow it.
Zephyr still use Linux kernel coding style and we will keep it for GigaDevices. I point 2 exceptions that are OK to use more than 80 columns.

Please, reformat code to use 80 columns.

[cameled]

This is a big step for the tansfer performence. Have a qiuck look, will try to run this on my gd32vf103v board latter.

[cameled]

For gd32f4xx series, only dma1 support m2m, and should use multi-data mode

EDIT: m2m multi-data mode auto applied by hardware.

[nandojve]

long lines...

-gd32_dma_interrupt_disable(cfg->reg, i, DMA_CHXCTL_FTFIE | GD32_DMA_INTERRUPT_ERRORS);
+gd32_dma_interrupt_disable(cfg->reg, i,
+                           DMA_CHXCTL_FTFIE |
+                           GD32_DMA_INTERRUPT_ERRORS);

[soburi]

Completed all fixes.
Sorry for taking up your time, but please review.

[cameled]

LGTM, dma loop_transfer test passed on my gd32f450i_eval and gd32f350r_eval boards.

[nandojve]

Please, keep at 80col, rework all file.

[soburi]

Rerun clang-format with ColumnLimit: 80

[teburd]

If the clang format settings aren’t the style guide this is the inevitable issue. Please file an issue or PR against the clang format settings. The docs suggest running it, and the settings define a style that should make code fit the zephyr style and avoid exactly this discussion, if not it’s something that should be fixed.

[nandojve]

+1

[nandojve]

Hi @soburi ,

There was an agreement to allow up to 100 col in code. This doesn't mean that we will follow it.
Zephyr still use Linux kernel coding style and we will keep it for GigaDevices. I point 2 exceptions that are OK to use more than 80 columns.

Please, reformat code to use 80 columns.

[teburd]

looks like a well written driver, very nice

[nandojve]

Hi @soburi ,

Thank you for the patience. You made a very good job!

[soburi]

Hi, @nandojve , @teburd , @cameled

Thank you for your review.
It's been a long review, but it's not the last.
Please also #47504. 😃