Skip to content

Conversation

@kabeljan
Copy link
Contributor

@kabeljan kabeljan commented Jul 8, 2022

The patch adds the counter API support for the STM32L4 series.
There are no changes to the previously implemented driver for the STM32F4 series (see #39414). Only device tree and test suite extensions where necessary, to confirm the ability of the existing driver for the STM32L4 series.
The test are implemented and run on nucleo_l476rg and nucleo_l433rc_p boards.

(A previous qualification alongside of the implementation were prevented by missing test capabilities of the original author)

@kabeljan kabeljan requested a review from FRASTM July 11, 2022 09:01
@kabeljan
Copy link
Contributor Author

@FRASTM I accidentally pushed the "request review" button on my phone, while viewing the PR on my phone. Sorry for that.

FRASTM
FRASTM previously approved these changes Jul 13, 2022
ABOSTM
ABOSTM previously approved these changes Jul 13, 2022
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kabeljan added 3 commits July 13, 2022 20:50
Add counter nodes to timer nodes in dts of stm32l4 series.
This should enable the support of the basic counter API
on all stm32l4 mcus for general-purpose and basic TIMx timers.

Signed-off-by: Jan Kablitz <[email protected]>
Add overlay for nucleo_l433rc_p to enable counter_basic_api
tests on this board. The prescalers of the timers will result
in a counter frequency of 1 MHz.

Signed-off-by: Jan Kablitz <[email protected]>
Add overlay for nucleo_l476rg to enable counter_basic_api
tests on this board. The prescalers of the timers will result
in a counter frequency of 1 MHz.

Signed-off-by: Jan Kablitz <[email protected]>
@kabeljan kabeljan dismissed stale reviews from ABOSTM and FRASTM via cdefe4d July 13, 2022 18:53
@kabeljan kabeljan force-pushed the counter_support_stm32l4_series branch from 4b0f844 to cdefe4d Compare July 13, 2022 18:53
@carlescufi carlescufi requested review from ABOSTM and FRASTM July 13, 2022 19:04
@carlescufi carlescufi merged commit 8e79af0 into zephyrproject-rtos:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants