-
Notifications
You must be signed in to change notification settings - Fork 8.2k
build: Overlay build vars expand ${ZEPHYR_<module>_MODULE_DIR} #47638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Overlay build vars expand ${ZEPHYR_<module>_MODULE_DIR} #47638
Conversation
1e4a8cb to
3f03fb4
Compare
|
Updated version of automatically closed PR #42057 |
tejlmand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please push the correct and approved version.
Current version is older with unaddressed comments.
doc/develop/application/index.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please push the correct version ?
This is old version where changes was requested here:
#42057 (comment)
note you most likely need to manually expand collapsed comments in github for the link to take you to the right comment.
Old comment copy:
Looking at the rendered output, I feel this particular feature fills to much, compared to the description of the other parts:
How about just a short mentioning of this possibility, for example:
| set(CONF_FILE "\${ZEPHYR_MODULENAME_MODULE_DIR}/<module-relative-pathname>") | |
| ``DTC_OVERLAY_FILE``. A file in a Zephyr module can be referred by escaping the Zephyr module dir variable like this ``\${ZEPHYR_<module>_MODULE_DIR}/<path-to>/<file>`` when setting any of said variables. |
3f03fb4 to
1d09a68
Compare
1d09a68 to
4044e04
Compare
|
@tejlmand Thank you for pointing out my mistake. I have corrected the changes that I could map to the current files. Some of the relevant documentation has been restructured. I will need some guidance on further documentation updates. |
tejlmand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
d99c90d
4044e04 to
d99c90d
Compare
|
Rebased, updated test source to new ZTest API. |
Support referencing module directories by name in CONF_FILE, OVERLAY_CONFIG, and DTC_OVERLAY_FILE so that projects can reference overlay files in arbitrary modules. Verified by passing all the following tests: ./scripts/twister -T tests/cmake/overlays/ Fixes zephyrproject-rtos#41830 Signed-off-by: Gregory Shue <[email protected]>
d99c90d to
2d3c4a6
Compare

Support referencing module directories by name in CONF_FILE,
OVERLAY_CONFIG, and DTC_OVERLAY_FILE so that projects can reference
overlay files in arbitrary modules.
Fixes #41830
Signed-off-by: Gregory Shue [email protected]