arch: rename 'SRAM' memory regions to 'RAM' where appropriate #49438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tari
force-pushed
the
arm-sram-region-rename
branch
from
55fafc7 to
fbb28f3
Compare
tari
requested review from
MaureenHelm,
carlocaione,
galak,
ioannisg,
nashif,
stephanosio and
tejlmand
as code owners
zephyrbot
added
area: Build System
area: ARM
zephyrbot
requested review from
SgrrZhf,
bbolen,
jeremybettis,
microbuilder,
npitre and
povergoing
edersondisouza
previously approved these changes
Aug 25, 2022
SgrrZhf
reviewed
Aug 25, 2022
tari
force-pushed
the
arm-sram-region-rename
branch
from
fbb28f3 to
8c8367d
Compare
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
danieldegrasse,
decsny and
yvanderv
tari
force-pushed
the
arm-sram-region-rename
branch
3 times, most recently
from
00e0ee5 to
07c7609
Compare
Contributor
I know, it was just an extra piece of info for you 😉 |
SgrrZhf
previously approved these changes
Sep 7, 2022
It's useful for RAMABLE_REGION to have a uniform name when CODE_DATA_RELOCATION is supported, because otherwise the build system needs to be aware of how the region name differs between architectures. Since architectures tend to prefer one of 'SRAM' or 'RAM' for that region, prefer to use 'RAM' as the more general term. Signed-off-by: Peter Marheine <[email protected]>
As with 32-bit ARM, it is useful to make the RAMABLE_REGION name uniform across architectures so the build system does not need to be aware of the differences when CODE_DATA_RELOCATION is supported. Generalize the name to just 'RAM' for uniformity. Signed-off-by: Peter Marheine <[email protected]>
It's useful for the default RAM region to have a uniform name across architectures so higher-level build processes do not need to have their own awareness of the names. Since NIOS2 uniformly uses 'SRAM', change it to 'RAM' to match most other architectures. Signed-off-by: Peter Marheine <[email protected]>
This was copied from the ARM version of the test's linker script, which in turn seems to have been copied from another linker script at some point. Remove the incorrect comment. Signed-off-by: Peter Marheine <[email protected]>
tari
force-pushed
the
arm-sram-region-rename
branch
from
07c7609 to
856e402
Compare
carlocaione
approved these changes
Sep 14, 2022
microbuilder
approved these changes
Sep 14, 2022
stephanosio
approved these changes
Sep 14, 2022
povergoing
approved these changes
Sep 14, 2022
fabiobaltieri
dismissed stale reviews from SgrrZhf and tejlmand
via
856e402
Member
|
Should this be considered a bugfix? (would queue for v3.3.otherwise since we are in feature freeze) |
Contributor
Author
|
I wouldn't call this a bugfix, since it doesn't affect normal usage. It's even a sort of breaking change, since users referring to |
tejlmand
approved these changes
Sep 28, 2022
SgrrZhf
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the default RAM region for the linker varies somewhat between architectures, generally either being
RAMorSRAM. Since it's useful at a higher level to have predictable memory region names (especially for theCODE_DATA_RELOCATIONfeature), this renamesSRAMregions toRAMfor architectures where that makes sense.RAMis chosen as the unified name becauseSRAMmay not be technically correct for some systems. Some SoCs and architectures have more complex memory layouts so they remain unchanged: they do not currently supportCODE_DATA_RELOCATIONwhich provides the motivation.This is a follow-up from #49262 to clean up some of the build configuration.