-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Update fff module tests #49981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fff module tests #49981
Conversation
yperess
commented
Sep 6, 2022
- Remove the module tests (they're no longer needed since upstream FFF runs better CI now)
- Update the header to match the pending PR at Support custom function signatures meekrosoft/fff#113
94a35e1 to
8a3722a
Compare
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
|
Failed compliance check is a false positive, the |
fee3747 to
aa02bf5
Compare
aa02bf5 to
36f2cfd
Compare
36f2cfd to
c3073b8
Compare
|
@carlescufi what do you think of this? The CI on fff has been updated to use github actions so we also will be running those on our fork (once that PR merges) but we have a chicken & egg issue that I can't merge those changes without rolling back the additional commit that allowed us to run the fff tests on our CI. What I'd like to do:
|
I have no objections with the proposed plan, but I'd like @stephanosio to weigh in on it as well. |
As long as the "roll back" and the "pull" are done in a non-destructive way (i.e. no force push), no objections. It is important that the commit(s) that are referenced by previous Zephyr releases are valid. |
c3073b8 to
e30a964
Compare
Yup, that's exactly what I had in mind, the PR is ready to go at https://github.com/zephyrproject-rtos/fff/pull/2/commits. You can see there that the first commit is a revert then a fetch from upstream. |
I've update FFF to run tests in the native CI for GitHub, so we no longer need to run these extra tests. Remove the fff module from west.yml since the module was only used in the CI and the header was directly included in the Zephyr tree. See zephyrproject-rtos/fff#2 Signed-off-by: Yuval Peress <[email protected]>
Update fff.h to the pending PR upstream which allows for using a custom function signature. This enables the use of C++ std::function as the mock. Signed-off-by: Yuval Peress <[email protected]>
e30a964 to
5e8d473
Compare