Skip to content

drivers: gpio: Add SDL simulated GPIO support #50080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2022
Merged

drivers: gpio: Add SDL simulated GPIO support #50080

merged 4 commits into from
Oct 3, 2022

Conversation

@pdgendt
Copy link
Contributor

@pdgendt pdgendt commented Sep 9, 2022 •
edited
Loading

This commit adds a driver to simulate GPIO state and interrupts from the keyboard when using SDL.

I still need to make it build in CI. Would it make sense to extend samples/subsys/display/lvgl with example usage?

@pdgendt pdgendt requested a review from vanwinkeljan September 9, 2022 10:04
@pdgendt pdgendt force-pushed the drivers-gpio-sdl branch 2 times, most recently from 72f7253 to 9e4fa3d Compare September 9, 2022 13:42
@pdgendt pdgendt marked this pull request as ready for review September 9, 2022 13:42
@pdgendt pdgendt requested review from galak and mnkp as code owners September 9, 2022 13:42
cfriedt
cfriedt reviewed Sep 10, 2022
View reviewed changes
Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite possible that you could wrap around the existing gpio_emul driver for this and provide only the callbacks.

Did you already attempt that?

@pdgendt pdgendt requested a review from nashif as a code owner September 13, 2022 12:52
@pdgendt
Copy link
Contributor Author

pdgendt commented Sep 13, 2022

It's quite possible that you could wrap around the existing gpio_emul driver for this and provide only the callbacks.

Thanks @cfriedt for the suggestion, I've modified the driver as suggested.

@pdgendt pdgendt force-pushed the drivers-gpio-sdl branch 2 times, most recently from c80f565 to 02fc1b0 Compare September 13, 2022 13:03
mbolivar-nordic
mbolivar-nordic previously approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petejohanson not sure if this is relevant to you but FYI.

Binding looks fine.

@petejohanson
Copy link
Contributor

petejohanson commented Sep 14, 2022

@petejohanson not sure if this is relevant to you but FYI.

Binding looks fine.

Interesting! Perhaps, yes. We right now do have the ability to run as a posix process for some testing we do, this might make that a tad simpler.

No issues w/ the PR, other than maybe a request for some docs for posterity?

@pdgendt
Copy link
Contributor Author

pdgendt commented Sep 14, 2022 •
edited
Loading

No issues w/ the PR, other than maybe a request for some docs for posterity?

Where would it make sense to add documentation? SDL is currently only mentioned in the native_posix board support page.

Also, I don't know why the CI fails, the sample fails to build for bl5340_dvk_cpuapp with undefined reference to '__device_dts_ord_14' which is caused by DT_ALIAS(sw0).

@pdgendt
drivers: gpio: pca953x: select I2C
7d67130 
Select I2C instead of depending on it, following upstream policy.

Signed-off-by: Pieter De Gendt <[email protected]>
@pdgendt
drivers: gpio: Add SDL emulated GPIO support
57d2614 
This commit adds a driver to simulate GPIO state and interrupts
using the keyboard when using SDL.

Signed-off-by: Pieter De Gendt <[email protected]>
@pdgendt
samples: subsys: display: lvgl: Add button to reset counter
14d1753 
Connect the sw0 alias to reset the counter.

Signed-off-by: Pieter De Gendt <[email protected]>
@pdgendt
samples: subsys: display: lvgl: Add native_posix overlay for SDL input
380bfc0 
Enable SDL keyboard events using the zephyr,gpio-emul-sdl driver and
alias key to sw0.
Pressing 'r' on the keyboard resets the counter.

Signed-off-by: Pieter De Gendt <[email protected]>
mbolivar-nordic
mbolivar-nordic approved these changes Sep 14, 2022
View reviewed changes
@fabiobaltieri fabiobaltieri added this to the v3.3.0 milestone Sep 16, 2022
@pdgendt pdgendt mentioned this pull request Sep 20, 2022
Merged
@carlescufi carlescufi merged commit fd81163 into zephyrproject-rtos:main Oct 3, 2022
@pdgendt pdgendt deleted the drivers-gpio-sdl branch October 5, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfriedt cfriedt cfriedt approved these changes

@vanwinkeljan vanwinkeljan Awaiting requested review from vanwinkeljan

@galak galak Awaiting requested review from galak

@mnkp mnkp Awaiting requested review from mnkp

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@nashif nashif Awaiting requested review from nashif

@gmarull gmarull Awaiting requested review from gmarull

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

+1 more reviewer

@mbolivar-nordic mbolivar-nordic mbolivar-nordic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mnkp mnkp

Labels

area: Devicetree area: Display area: GPIO

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

8 participants

@pdgendt @petejohanson @cfriedt @mbolivar-nordic @fabiobaltieri @carlescufi @zephyrbot @mnkp