TF-M: Add option to enable SFN model #50556
Conversation
zephyrbot
added
area: TF-M
microbuilder
left a comment
microbuilder
left a comment
There was a problem hiding this comment.
Tiny nit, sorry, but requesting changes since CI failing anyway.
There was a problem hiding this comment.
Super nit, but since there is a CI failure we may as well fix this at the same time as any update:
| The SFN model support the SFN Partition model, and the isolation | |
| levels 1. | |
| The SFN model supports the SFN Partition model, and isolation | |
| level 1. |
There was a problem hiding this comment.
Spelling is Kconfig help text is not nit ;)
|
@theotherjimmy Do you have any bandwidth to have a look at that failure on the lpc55s69, since you have some experience with that part, and I'm not sure @joerchan has one available? |
|
@microbuilder @theotherjimmy I suspect the lpc55 issue is related to TFM_IPC being default now, and this has an issue for the board. Maybe we could check if this is an issue on the main branch as well. We could put this board as default Library model for the time and open an issue to resolve it later. |
joerchan
force-pushed
the
tfm-sfn-upstream
branch
from
c83a3cb to
5bbf5d9
Compare
|
@theotherjimmy It is a kconfig / cmake issue, so you don't have too look into this problem. I can fix this myself. |
joerchan
force-pushed
the
tfm-sfn-upstream
branch
from
5bbf5d9 to
9375a71
Compare
|
CI Issue resolved. Conditional prompt on a choice symbol meant that none of the options was selected, which is not a valid. |
joerchan
force-pushed
the
tfm-sfn-upstream
branch
from
9375a71 to
d07ae78
Compare
joerchan
force-pushed
the
tfm-sfn-upstream
branch
from
d07ae78 to
5cb6907
Compare
SebastianBoe
left a comment
SebastianBoe
left a comment
There was a problem hiding this comment.
Very nicely configured.
soc/arm/nordic_nrf/nrf53/soc.c
Outdated
There was a problem hiding this comment.
The BOARD_NRF_GPIO_FORWARDER_FOR_NRF5340 option is defined as available only for nrf5340dk_nrf5340_cpuapp* targets, but also others, like thingy53_nrf5340_cpuapp* and bl5340_dvk_cpuapp*, need to use the code wrapped in this #if.
There was a problem hiding this comment.
Thanks. I moved the Kconfig to SOC common, since it affects nrf53/soc.c, and then all boards need to select it on their BOARD_ENABLE_CPUNET.
Make Kconfig produce an error when GPIOs cannot be forwarded in the current configuration instead of silently excluding the forwarding. Signed-off-by: Joakim Andersson <[email protected]>
Allow building for nRF non-secure and TF-M enabled without having the platform partition enabled. In this configuration the soc_secure functions have no valid implementation, leave it as a compilation error if the application includes the functions. Add missing dependency on soc_secure functions being available for SOC_HFXO_CAP_INTERNAL configuration. Signed-off-by: Joakim Andersson <[email protected]>
Add option to enable the SFN model when building TF-M. The SFN model will eventually replace the Library model. Change the default model to be IPC, which follows the default configuration of TF-M. Signed-off-by: Joakim Andersson <[email protected]>
joerchan
force-pushed
the
tfm-sfn-upstream
branch
from
5cb6907 to
52e7669
Compare
8 participants
Add option to enable the SFN model when building TF-M.
The SFN model will eventually replace the Library model.
Change the default model to be IPC, which follows the default
configuration of TF-M.
Allow building for nRF non-secure and TF-M enabled without having the
platform partition enabled.