sysbuild: Fix board revisions not being passed to target images #52369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherish-Gww
reviewed
Nov 21, 2022
nordicjm
force-pushed
the
sysbuild_revision_fix
branch
from
eae6b44 to
d5a7589
Compare
tejlmand
requested changes
Dec 8, 2022
Contributor
tejlmand
left a comment
tejlmand
left a comment
There was a problem hiding this comment.
something related to sysbuild cache sharing looks wrong.
Taking a look.
nordicjm
force-pushed
the
sysbuild_revision_fix
branch
from
d5a7589 to
a64fec1
Compare
Contributor
|
@nordicjm fixed the root cause here: #52884 This PR is still valid, as it provides a mechanism for project to specify not only board but also revision, however as mentioned #52369 (comment) the else part should not be needed. |
nordicjm
force-pushed
the
sysbuild_revision_fix
branch
from
a64fec1 to
c4f8e2e
Compare
nordicjm
requested review from
Cherish-Gww and
tejlmand
and removed request for
Cherish-Gww
nordicjm
force-pushed
the
sysbuild_revision_fix
branch
from
c4f8e2e to
780e2da
Compare
Allows specifying board revisions when configuring target images with sysbuild. Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
force-pushed
the
sysbuild_revision_fix
branch
from
780e2da to
010358b
Compare
tejlmand
approved these changes
Jan 3, 2023
carlescufi
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue whereby board revisions were not being passed to target images and adds a new flag that allows passing the board revision to target images for different target boards but preserving the board revision.
Fixes #52353