Skip to content

Conversation

@zephyrbot
Copy link

@zephyrbot zephyrbot commented Apr 10, 2023

Fixes #56067

Backport 39af513~9..39af513 from #50049

Clang 15 added a new warning type `-Wdeprecated-non-prototype` that
warns about the functions without prototypes, which have been
deprecated since the C89 and will not work in the upcoming C2x.

This commit disables the warning because Zephyr deliberately makes use
of the functions without prototypes to allow the use of a "generic"
function pointer (notoriously in the cbprintf implementation) and
Zephyr will not move to the C2x in the foreseeable future.

Signed-off-by: Stephanos Ioannidis <[email protected]>
(cherry picked from commit 0a63ca6)
This commit removes stale clang-related variables that are not used by
the Twister workflow.

Signed-off-by: Stephanos Ioannidis <[email protected]>
(cherry picked from commit 34e4b6f)
This commit removes stale clang-related variables that are not used by
the codecov workflow.

Signed-off-by: Stephanos Ioannidis <[email protected]>
(cherry picked from commit bbe32d4)
This commit removes stale clang-related variables that are not used by
the bluetooth-tests workflow.

Signed-off-by: Stephanos Ioannidis <[email protected]>
(cherry picked from commit 984731c)
This commit removes stale clang-related variables that are not used by
the footprint-tracking workflow.

Signed-off-by: Stephanos Ioannidis <[email protected]>
(cherry picked from commit 02fbef5)
This commit removes stale clang-related variables that are not used by
the footprint workflow.

Signed-off-by: Stephanos Ioannidis <[email protected]>
(cherry picked from commit ba14a4e)
`CLANG_ROOT_DIR` is deprecated; use `LLVM_TOOLCHAIN_PATH` instead.

Signed-off-by: Stephanos Ioannidis <[email protected]>
(cherry picked from commit e43aebb)
This commit updates the CI workflows to use the CI image 0.24.3, in
order to pull in the LLVM/Clang 15 and Renode 1.13.1.

Signed-off-by: Stephanos Ioannidis <[email protected]>
(cherry picked from commit e5b17ee)
This commit updates the Clang workflow to build tests using Clang 15.

Signed-off-by: Stephanos Ioannidis <[email protected]>
(cherry picked from commit 39af513)
@stephanosio
Copy link
Member

@galak Since you requested this backport, could you provide some rationale on why this is necessary?

@galak
Copy link
Contributor

galak commented Apr 25, 2023

@galak Since you requested this backport, could you provide some rationale on why this is necessary?

The first commit is needed for arm-clang to build w/o everything causing warnings. I just tagged the original PR and thus is backported all the commits from it.

Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem with this since the Zephyr SDK version has not changed as part of this update, and the update to Clang 15 does not introduce any breaking changes.

@stephanosio stephanosio added the DNM This PR should not be merged (Do Not Merge) label Apr 25, 2023
@stephanosio
Copy link
Member

DNM until the node image is updated to cache the CI image v0.24.3.

@stephanosio stephanosio removed the DNM This PR should not be merged (Do Not Merge) label Apr 29, 2023
@stephanosio
Copy link
Member

DNM until the node image is updated to cache the CI image v0.24.3.

Node image has been updated. Merging.

@stephanosio stephanosio merged commit 9e27dda into v3.2-branch Apr 29, 2023
@nashif nashif deleted the backport-50049-to-v3.2-branch branch February 13, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants