boards: Remove default kscan touch enabling #62107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faxe1008
force-pushed
the
board_remove_kscan
branch
2 times, most recently
from
b3fb3b8 to
6890a88
Compare
faxe1008
requested review from
ABOSTM,
FRASTM,
MaureenHelm,
aescolar,
daor-oti,
dleach02,
erwango,
galak,
mmahadevan108 and
nashif
as code owners
zephyrbot
added
area: Display
area: native port
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
danieldegrasse,
decsny and
yvanderv
fabiobaltieri
requested review from
fabiobaltieri
and removed request for
decsny
faxe1008
force-pushed
the
board_remove_kscan
branch
from
6890a88 to
a4fa1e8
Compare
fabiobaltieri
previously approved these changes
Sep 4, 2023
erwango
reviewed
Sep 4, 2023
Change boards and shields which enable the LV_Z_POINTER_KSCAN symbol to use the new "zephyr,lvgl-pointer-input" compatible instead. Signed-off-by: Fabian Blatz <[email protected]>
After adding the lvgl pointer device into the board dts the custom overlays are not needed anymore. Signed-off-by: Fabian Blatz <[email protected]>
Change boards and shields and remove kscan nodes in favor of the "zephyr,lvgl-pointer-input" compatible. Signed-off-by: Fabian Blatz <[email protected]>
Update the expected output of the init priority checking. Signed-off-by: Fabian Blatz <[email protected]>
faxe1008
force-pushed
the
board_remove_kscan
branch
from
a4fa1e8 to
a54df10
Compare
Contributor
Author
|
Addressed @erwango note regarding naming of nodes within shields. |
Member
Up to you, does it break the build to have that change in its own commit? |
Contributor
Author
Build should succeed regardless of the squashing. If you want to I'll squash, for me its fine as is :^). |
Member
Ok so fine as is. |
fabiobaltieri
approved these changes
Sep 4, 2023
erwango
approved these changes
Sep 5, 2023
Member
erwango
left a comment
erwango
left a comment
There was a problem hiding this comment.
Approved (even if I can't see the proposed changed, so will have to be fixed in an upcoming PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to the PR: pull/60867
The goal is basically to remove the depedency of lvgl on the kscan nodes. This means in any case the
defconfigswhereKSCANandLV_Z_POINTER_KSCANare enabled need to be edited.I split the removal of the kscan nodes into a separate commit since I am not sure if the fact that this will break downstream applications breaks any sort of deprecation timeline. If its fine I can squash the commit 3 into the first one.
If having the pointer be a freestanding node is a concern, I'd be happy to change
zephyr,lvgl-pointer-inputto be similar to the waykscan-inputworked prior. Feedback on this would also be appreciated :^)