cmake: set big-endian flags to TOOLCHAIN_*_FLAGS #73563
Conversation
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm,
stephanosio and
tejlmand
ntavish
force-pushed
the
fix/enable-armv7-r-big-endian-multilib
branch
from
6b1602f to
2ecc9f6
Compare
ntavish
force-pushed
the
fix/enable-armv7-r-big-endian-multilib
branch
from
d208272 to
d8d4a87
Compare
tejlmand
left a comment
tejlmand
left a comment
There was a problem hiding this comment.
Seems ok, but some small clarification is needed as this doesn't seem to really add support for big endian on v7-r.
Also this help text needs an update, as it doesn't include the flags on the compiler.
Lines 183 to 184 in 2457f73
cmake/compiler/gcc/target_arm.cmake
Outdated
There was a problem hiding this comment.
currently BIG_ENDIAN is a promptless symbol, meaning it depends on something having a select BIG_ENDIAN (or a change of default).
Currently the arch for which that is done is SPARC:
Line 65 in 2457f73
Line 70 in 2457f73
so how is this expected to be selected for arm v7-r and thus selecting this code path ?
There was a problem hiding this comment.
There seems to be no board with such a combination, but I am working on porting zephyr to TI TMS570. Seems like a couple more people have out of tree support for these, see: #72696
Since SPARC toolchain is simply big-endian only, these flags not being passed to it may not matter, so we do not see problem (I think).
ntavish
force-pushed
the
fix/enable-armv7-r-big-endian-multilib
branch
from
d8d4a87 to
74bfdf3
Compare
Set -big-endian to both compiler and linker flags if CONFIG_BIG_ENDIAN is set. Signed-off-by: Tavish Naruka <[email protected]>
|
@tejlmand sorry for the delay, made the changes you have requested for |
Sorry, but I don't see any reply to this comment: #73563 (comment) |
Oops, it was still 'pending', should be visible now. |
5 participants
This PR is related to zephyrproject-rtos/sdk-ng#765