soc: renesas: ra: ra4m1: Migrate to FSP-based configuration #76794

soburi · 2024-08-07T13:21:45Z

Change to use FSP to integrate with other Renesas RA series.

zephyrbot · 2024-08-07T13:22:46Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

KhiemNguyenT

@soburi , I think you need to brush up the PR. There are some changes for RA2A1 are mixed into.

soburi · 2024-09-02T05:43:07Z

@KhiemNguyenT

@soburi , I think you need to brush up the PR. There are some changes for RA2A1 are mixed into.

Update done.
I will remove DNM and proceed once the following PR in hal_renesas is approved.

zephyrproject-rtos/hal_renesas#31

gmarull · 2024-09-06T10:34:22Z

dts/arm/renesas/ra/ra-cm4-common.dtsi

wrong:

source: define another clock and make it source using eg clocks = <&main_osc>;

divider should be given as integer div = <2>;.

@duynguyenxa @quytranpzz
Are these properties actually used?

@soburi , these properties are used to provide information for the bsp_clock_cfg.h in the hal layer:

#define BSP_CFG_PLL_SOURCE \ BSP_CLOCK_PROP_HAS_STATUS_OKAY_OR(DT_NODELABEL(pll), source, RA_PLL_SOURCE_DISABLE) #define BSP_CFG_PLL_DIV BSP_CLOCK_PROP_HAS_STATUS_OKAY_OR(DT_NODELABEL(pll), div, RA_PLL_DIV_2) #if DT_NODE_HAS_STATUS(DT_NODELABEL(pll), okay)

The BSP_CFG_PLL_SOURCE, and BSP_CFG_PLL_DIV BSP will be used in the bsp_clock_init() to configure PLL clock.

FYI: We can't have HALisms in DT.

@gmarull , the macro is defined in zephyr main repo, zephyr/include/zephyr/dt-bindings/clock/ra_clock.h

it still looks wrong, why isn't div = <2>? Are such values encoding what HAL expects?

@gmarull , sorry for late response, it's expect the value map with HWM here for the pll.

@duynguyenxa

The root of this problem is that the DeviceTree is a hardware description language,
and how values are handled should not be mixed in here.
In other words, the DeviceTree should be able to describe semantic values; for example, if the division factor is 2, then it should be describable as "2", and it should be up to the implementation side, i.e., the .h or .c file, to convert this to bit notation.

I splitted out this issue to #78365.

#78365 is already merged.

gmarull · 2024-09-06T10:34:41Z

dts/arm/renesas/ra/ra-cm4-common.dtsi

no underscores in properties please.

I have created #78097.
I will fix it after this PR is merged.

#78097 is already merged.

soburi · 2024-10-31T20:30:24Z

@KhiemNguyenT
Please approve if it is good for you.

tejlmand

lgtm, a minot nit observed but not blocking.

tejlmand · 2024-11-01T08:41:10Z

soc/renesas/ra/ra4m1/CMakeLists.txt

minor nit, not blocking.

No need for linewrap anymore.

Thank you for your feedback.
I fixed it.

Change to use FSP to integrate with other Renesas RA series. Signed-off-by: TOKITA Hiroshi <[email protected]>

Since the Option Setting Memory area is set in FSP, the Kconfig value switches between using the FSP implementation or the existing Option Setting Memory implementation. Signed-off-by: TOKITA Hiroshi <[email protected]>

Switch the pinctrl driver to renesas,ra-pinctrl-pfs which can be used with FSP. Signed-off-by: TOKITA Hiroshi <[email protected]>

Switch the clock controller driver to renesas,ra-cgc-pclkblock which can be used with FSP. Signed-off-by: TOKITA Hiroshi <[email protected]>

Update configuration for migrate to FSP Signed-off-by: TOKITA Hiroshi <[email protected]>

This PR fixes zephyrproject-rtos#78619 for the Arduino UNO R4 Minima/Wifi board. Signed-off-by: TOKITA Hiroshi <[email protected]>

Remove the renesas,ra-pinctrl driver, which is no longer needed after migrating to the FSP-based implementation. Signed-off-by: TOKITA Hiroshi <[email protected]>

Remove the renesas,ra-clock-generation-circuit driver, which is no longer needed after migrating to the FSP-based implementation. Signed-off-by: TOKITA Hiroshi <[email protected]>

soburi · 2024-11-16T23:25:17Z

@KhiemNguyenT
Please take a look.

KhiemNguyenT

Thank you for this action.
LGTM.

soburi added the DNM This PR should not be merged (Do Not Merge) label Aug 7, 2024

zephyrbot added manifest manifest-hal_renesas labels Aug 7, 2024

soburi force-pushed the ra4m1_migrate_to_fsp branch from 2840072 to 78cb002 Compare August 8, 2024 09:28

KhiemNguyenT requested review from KhiemNguyenT, duynguyenxa and thaoluonguw August 21, 2024 11:02

KhiemNguyenT requested changes Aug 21, 2024

View reviewed changes

soburi force-pushed the ra4m1_migrate_to_fsp branch from 78cb002 to 6da34c3 Compare August 21, 2024 15:49

KhiemNguyenT self-assigned this Aug 21, 2024

soburi mentioned this pull request Aug 22, 2024

Support Renesas RA4 devices #76081

Merged

soburi force-pushed the ra4m1_migrate_to_fsp branch 4 times, most recently from 0708bdb to b58b9d0 Compare September 1, 2024 08:26

soburi marked this pull request as ready for review September 2, 2024 05:43

zephyrbot added area: GPIO area: Pinctrl platform: Renesas RA Renesas Electronics Corporation, RA area: Clock Control area: UART Universal Asynchronous Receiver-Transmitter labels Sep 2, 2024

zephyrbot requested review from dcpleung, gmarull, henrikbrixandersen, mnkp and nordic-krch September 2, 2024 05:44

soburi requested a review from KhiemNguyenT September 4, 2024 12:08

gmarull requested changes Sep 6, 2024

View reviewed changes

duynguyenxa previously approved these changes Oct 29, 2024

View reviewed changes

tejlmand previously approved these changes Nov 1, 2024

View reviewed changes

soburi added 9 commits November 1, 2024 18:14

soc: renesas: ra: ra4m1: Migrate to FSP-based configuration

0fcfa30

Change to use FSP to integrate with other Renesas RA series. Signed-off-by: TOKITA Hiroshi <[email protected]>

soc: renesas: ra: ra4m1: Adapts the Option Setting Memory to FSP.

3ec1008

Since the Option Setting Memory area is set in FSP, the Kconfig value switches between using the FSP implementation or the existing Option Setting Memory implementation. Signed-off-by: TOKITA Hiroshi <[email protected]>

dts: arm: renesas: ra4: Use renesas,ra-pinctrl-pfs driver

2954fa6

Switch the pinctrl driver to renesas,ra-pinctrl-pfs which can be used with FSP. Signed-off-by: TOKITA Hiroshi <[email protected]>

dts: arm: renesas: ra4: Use renesas,ra-cgc-pclkblock driver

db19098

Switch the clock controller driver to renesas,ra-cgc-pclkblock which can be used with FSP. Signed-off-by: TOKITA Hiroshi <[email protected]>

boards: mikroe: clicker_ra4m1: Migrate to FSP

f7cb154

Update configuration for migrate to FSP Signed-off-by: TOKITA Hiroshi <[email protected]>

boards: arduino: uno_r4: Migrate to FSP

8ed2b50

Update configuration for migrate to FSP Signed-off-by: TOKITA Hiroshi <[email protected]>

boards: arduino: uno_r4: remove CONFIG_PINCTRL from defconfig of uno_r4

cb0d010

This PR fixes zephyrproject-rtos#78619 for the Arduino UNO R4 Minima/Wifi board. Signed-off-by: TOKITA Hiroshi <[email protected]>

drivers: pinctrl: Remove renesas,ra-pinctrl driver

995370a

Remove the renesas,ra-pinctrl driver, which is no longer needed after migrating to the FSP-based implementation. Signed-off-by: TOKITA Hiroshi <[email protected]>

drivers: clock_contrl: Remove renesas,ra-clock-generation-circuit driver

49b63b1

Remove the renesas,ra-clock-generation-circuit driver, which is no longer needed after migrating to the FSP-based implementation. Signed-off-by: TOKITA Hiroshi <[email protected]>

soburi dismissed stale reviews from tejlmand, duynguyenxa, thaoluonguw, and nordicjm via 49b63b1 November 1, 2024 09:15

soburi force-pushed the ra4m1_migrate_to_fsp branch from 18c25df to 49b63b1 Compare November 1, 2024 09:15

soburi requested review from duynguyenxa, nordicjm, tejlmand and thaoluonguw November 1, 2024 19:15

thaoluonguw approved these changes Nov 3, 2024

View reviewed changes

soburi modified the milestones: v4.0.0, v4.1.0 Nov 4, 2024

nordicjm approved these changes Nov 12, 2024

View reviewed changes

duynguyenxa approved these changes Nov 20, 2024

View reviewed changes

KhiemNguyenT approved these changes Nov 20, 2024

View reviewed changes

fabiobaltieri merged commit 43db55a into zephyrproject-rtos:main Nov 20, 2024
26 checks passed

soburi deleted the ra4m1_migrate_to_fsp branch November 20, 2024 13:13

soc: renesas: ra: ra4m1: Migrate to FSP-based configuration #76794

soc: renesas: ra: ra4m1: Migrate to FSP-based configuration #76794

Uh oh!

Conversation

soburi commented Aug 7, 2024

Uh oh!

zephyrbot commented Aug 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KhiemNguyenT left a comment

Choose a reason for hiding this comment

Uh oh!

soburi commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soburi Sep 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soburi commented Oct 31, 2024

Uh oh!

tejlmand left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soburi commented Nov 16, 2024

Uh oh!

KhiemNguyenT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

zephyrbot commented Aug 7, 2024 •

edited

Loading

soburi commented Sep 2, 2024 •

edited

Loading

soburi Sep 6, 2024 •

edited

Loading