openamp: resource table: fixes resource table to work with ram_console section #77293
Conversation
|
Hi @mausys can you make sure that the CI is all green? |
mausys
force-pushed
the
fix_ram_console
branch
from
c0826c4 to
d257d64
Compare
mausys
force-pushed
the
fix_ram_console
branch
from
d257d64 to
3272b1f
Compare
|
This change is also included in #79605 |
|
cc @alxlastur @Zhiqiang-Hou |
lib/open-amp/resource_table.c
Outdated
There was a problem hiding this comment.
Is'nt it sufficient to just use the extern to get the already defined ram_console_buf. This has the RAM_CONOLE_BUF_ATTR defined for it which should place it in the appropriate RAM section.
There was a problem hiding this comment.
The ram_console_buf in ram_console.c is only used when CONFIG_RAM_CONSOLE_BUFFER_SECTION is disabled. That's why I changed it in ram_console.c to not wasting memory.
There was a problem hiding this comment.
For the condition CONFIG_RAM_CONSOLE_BUFFER_SECTION, the RAM_CONOLE_BUF_ATTR is for putting it in the RAM section, so no memory wasting. keep the ram_console_buf for both conditions to avoid to determine the RAM section condition in the caller.
drivers/console/ram_console.c
Outdated
There was a problem hiding this comment.
revert this and directly use extern char ram_console_buf[]; in lib/open-amp/resource_table.c.
mausys
force-pushed
the
fix_ram_console
branch
2 times, most recently
from
5a47c85 to
09ecb39
Compare
in commit 1cd37f2 the global ram console buffer was replaced with a pointer. This didn't work with the OpenAMP resource table anymore (zephyrproject-rtos#75656). Signed-off-by: Simon Maurer <[email protected]>
mausys
force-pushed
the
fix_ram_console
branch
from
09ecb39 to
37d5bd1
Compare
|
@carlocaione, can you help review this again. |
|
@carlocaione , can you help take a look. This bug fix can be included in 4.0 release |
7 participants
in commit 1cd37f2 the global ram console buffer was replaced with a pointer. This didn't work with the OpenAMP resource table anymore (#75656). This commit removes also the unnecessary console buffer, if a ram console device tree node is configured.
Fixes #75656