Skip to content

Conversation

@Thalley
Copy link
Contributor

@Thalley Thalley commented Aug 22, 2024

Added initial CCP client implementation that simply does discovery of TBS on a remote CCP server.

@Thalley Thalley force-pushed the ccp_client_discove branch 2 times, most recently from 2f608c1 to 6121c15 Compare August 26, 2024 19:05
@Thalley Thalley force-pushed the ccp_client_discove branch 3 times, most recently from 1156a5f to 6cb38fa Compare September 9, 2024 09:45
@Thalley Thalley force-pushed the ccp_client_discove branch 5 times, most recently from a522939 to e9a5f7d Compare September 17, 2024 08:56
@Thalley Thalley force-pushed the ccp_client_discove branch 17 times, most recently from 345bf69 to c40668d Compare September 26, 2024 13:02
@Thalley Thalley force-pushed the ccp_client_discove branch 3 times, most recently from 15e59b5 to e027379 Compare October 3, 2024 10:52
larsgk
larsgk previously approved these changes Jan 20, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered this comment unnecessary - but also nice for newcomers to better understand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it makes sense in a sample

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too - and we should probably do more like this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For real devices, would this also need BT_SECURITY_FORCE_PAIR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really - If we are already bonded we don't need to create a new pairing each time

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contrained -> constrained

babrsn
babrsn previously approved these changes Jan 21, 2025
Copy link

@babrsn babrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thalley Thalley dismissed stale reviews from babrsn and larsgk via 017ba70 January 21, 2025 11:56
@Thalley Thalley force-pushed the ccp_client_discove branch from e6d1651 to 017ba70 Compare January 21, 2025 11:56
@Thalley
Copy link
Contributor Author

Thalley commented Jan 21, 2025

Rebased to solve merge conflicts

@Thalley Thalley requested review from babrsn and larsgk January 21, 2025 11:57
@Thalley Thalley force-pushed the ccp_client_discove branch from 017ba70 to 062cdb1 Compare January 21, 2025 12:05
larsgk
larsgk previously approved these changes Jan 21, 2025
babrsn
babrsn previously approved these changes Jan 21, 2025
@Thalley Thalley dismissed stale reviews from babrsn and larsgk via aaa7325 January 21, 2025 14:21
@Thalley Thalley force-pushed the ccp_client_discove branch from 062cdb1 to aaa7325 Compare January 21, 2025 14:21
@Thalley Thalley requested review from babrsn and larsgk January 21, 2025 14:21
@Thalley
Copy link
Contributor Author

Thalley commented Jan 21, 2025

Fixed broken test

@Thalley Thalley force-pushed the ccp_client_discove branch 2 times, most recently from f294435 to b4689b8 Compare January 22, 2025 07:38
babrsn
babrsn previously approved these changes Jan 22, 2025
Added initial CCP client implementation that simply
does discovery of TBS on a remote CCP server.

Signed-off-by: Emil Gydesen <[email protected]>
@Thalley
Copy link
Contributor Author

Thalley commented Jan 23, 2025

Removed CONFIG_BT_SEND_ECC_EMULATION from samples after #84268 was merged

@kartben kartben merged commit 9688c2d into zephyrproject-rtos:main Jan 28, 2025
27 checks passed
@Thalley Thalley deleted the ccp_client_discove branch January 28, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Bluetooth Audio area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth area: Samples Samples platform: nRF BSIM Nordic Semiconductors, nRF BabbleSim

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants