drivers: mipi_dbi: nxp_lcdic: add support for 8080 mode #77577
Conversation
danieldegrasse
force-pushed
the
feature/rw612-8080
branch
2 times, most recently
from
b144d36 to
00ce2a5
Compare
danieldegrasse
force-pushed
the
feature/rw612-8080
branch
from
00ce2a5 to
7458b27
Compare
danieldegrasse
requested review from
dleach02 and
mmahadevan108
as code owners
zephyrbot
added
area: Shields
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
MarkWangChinese,
avisconti,
butok,
dbaluta,
decsny,
erwango,
jfischer-no,
kartben,
manuargue and
yvanderv
There was a problem hiding this comment.
why is this deleted? might want to mention in commit message
There was a problem hiding this comment.
I've added a blurb in the commit message. For anyone interested, the best I can tell this was working because the FRDM-MCXN947 board (previously the only in tree board using this display) was configuring the INT pin for the display in the MIPI-DBI pincontrol node. The pin control setting was such that when the RESET pin for the display (and touch screen) controller is toggled low, the touch screen controller will select the 0x14 alternate I2C address. This workaround wasn't working on the RW612 board, so I opted to properly set initialization order, thereby making sure the GT911 driver is able to pull the reset pin low and set the INT pin properly as needed to get the GT911 IC to select the standard 0x5D I2C address.
danieldegrasse
force-pushed
the
feature/rw612-8080
branch
from
7458b27 to
750cbfe
Compare
dts/bindings/mipi-dbi/nxp,lcdic.yaml
Outdated
There was a problem hiding this comment.
Do you want to remove "Only SPI mode is currently supported."(L:6)?
There was a problem hiding this comment.
Yes, we should. I'll update this PR, thanks for catching that
danieldegrasse
force-pushed
the
feature/rw612-8080
branch
from
750cbfe to
3570358
Compare
kartben
left a comment
kartben
left a comment
There was a problem hiding this comment.
Minor doc comment -- we now have a "--shield" west arg
There was a problem hiding this comment.
| :gen-args: -DSHIELD=adafruit_2_8_tft_touch_v2 | |
| :shield: adafruit_2_8_tft_touch_v2 |
There was a problem hiding this comment.
| :gen-args: -DSHIELD=lcd_par_s035_8080 | |
| :shield: lcd_par_s035_8080 |
drivers/display/display_st7796s.c
Outdated
There was a problem hiding this comment.
| * invert the reported pixel format if rgb_is_inverted" | |
| * invert the reported pixel format if "rgb_is_inverted" |
There was a problem hiding this comment.
@danieldegrasse Shouldn't this be renamed to something generic prefixed with zephyr_ as we did in #77854? This way the shield's overlay can be used with boards from multiple vendors as is.
There was a problem hiding this comment.
This is a good point, it should be. I'll add a commit into this PR doing that cleanup.
danieldegrasse
dismissed stale reviews from decsny and jfischer-no
via
28baf38
danieldegrasse
force-pushed
the
feature/rw612-8080
branch
from
3570358 to
28baf38
Compare
Although the parallel mipi dbi mode pinout used for the LCD PAR S035 display is specific to NXP boards, the definition of the display is generic, and does not require NXP-specific parallel mipi dbi IP. Therefore, rename the MIPI DBI node for this display from `nxp_flexio_lcd` to `zephyr_mipi_dbi_parallel`. The gpio-nexus node name is unchanged, as the pinout it describes is specific to NXP. Signed-off-by: Daniel DeGrasse <[email protected]>
Update ST7796s display driver to respect the setting of rgb_is_inverted in 8080 8 bit mode, as it was previously not applied for this mode. Also, simplify the logic check for 16 bit mode- the new check is functionally equivalent, but no longer inverts both boolean values. Signed-off-by: Daniel DeGrasse <[email protected]>
Enable support for 8 bit 8080 mode in the NXP LCDIC driver. Support for programming the minimum duration of the write active/inactive signal is also added, since this will be required to support high display clocks in 8080 mode. Signed-off-by: Daniel DeGrasse <[email protected]>
The LCD_PAR_S035 display module shares the reset pin between the display module and the touchscreen controller. The touchscreen controller needs the reset pin to be toggled low during boot in order to select the expected I2C address. However, the reset sequence must occur before the display is initialized. To enable this, set a custom INPUT driver init priority when using this display module, so that INPUT drivers start after MIPI DBI drivers but before DISPLAY drivers. Since the reset sequence is now operating as expected, we no longer need to use the alt-addr probing method. This method was previously only working correctly because boards using this display were configuring the display INT pin using the pin control API prior to resetting the display, so when the display was reset it would select the alt-addr I2C address. Signed-off-by: Daniel DeGrasse <[email protected]>
Enable the rd_rw612_bga board with the LCD_PAR_S035 shield. This shield cannot be connected directly to the board, but the connection can be made with a set of jumper wires. Signed-off-by: Daniel DeGrasse <[email protected]>
Add documentation about supported displays on this board, as the list is getting rather long and each display has its own bespoke connection requirements. Signed-off-by: Daniel DeGrasse <[email protected]>
danieldegrasse
force-pushed
the
feature/rw612-8080
branch
from
28baf38 to
7a3586c
Compare
|
Rebased to pick up CI fixes |
|
@kartben ping- could you take another look at this PR? |
9 participants
Enable support for 8080 mode on the NXP LCDIC peripheral. This support has been validated on the
rd_rw612_bgaboard usinglcd_par_s035_8080shield, with the following samples:samples/drivers/displaysamples/modules/lvgl/demosAdditionally, this PR was tested on the
frdm_mcxn947//cpu0using thelcd_par_s035_8080shield withsamples/modules/lvgl/demos.Depends on #77578, #77579, and #77584 for various driver fixes (commits from those PRs are currently included in this one)Blocked by #78415 due a CI fix needed