Skip to content

soc: infineon: Support for power management on 20829 #77901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2024
Merged

soc: infineon: Support for power management on 20829 #77901

merged 1 commit into from
Nov 16, 2024

Conversation

@sreeramIfx
Copy link
Contributor

@sreeramIfx sreeramIfx commented Sep 3, 2024 

- Initial changes in board, dts, and soc files to support system power management

@sreeramIfx sreeramIfx force-pushed the topic/cyw20829_pm branch 4 times, most recently from be2db29 to 6599a3f Compare September 4, 2024 22:07
@sreeramIfx sreeramIfx marked this pull request as ready for review September 4, 2024 22:25
@zephyrbot zephyrbot added the platform: Infineon Infineon Technologies AG label Sep 4, 2024
ifyall
ifyall previously approved these changes Sep 26, 2024
View reviewed changes
gmarull
gmarull requested changes Sep 27, 2024
View reviewed changes
boards/infineon/cyw920829m2evk_02/cyw920829m2evk_02.dts Outdated
Comment on lines 28 to 46
Copy link
Member

@gmarull gmarull Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

power states need to be part of soc dts files

Copy link
Contributor Author

@sreeramIfx sreeramIfx Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved the power states to soc dtsi files..

Copy link
Contributor

@ifyall ifyall Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmarull, please review Sreeram's change at your convenience.

@sreeramIfx sreeramIfx force-pushed the topic/cyw20829_pm branch 2 times, most recently from 5408dad to dfd6c7e Compare October 2, 2024 23:10
@sreeramIfx
Copy link
Contributor Author

sreeramIfx commented Oct 3, 2024

Build failure is addressed @ #79399

gmarull
gmarull reviewed Oct 4, 2024
View reviewed changes
soc/infineon/cat1b/cyw20829/power.c Outdated
Copy link
Member

@gmarull gmarull Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, use hooks

Copy link
Contributor Author

@sreeramIfx sreeramIfx Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to use hooks

dts/arm/infineon/cat1b/cyw20829/cyw20829.dtsi Outdated
Copy link
Member

@gmarull gmarull Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in cpus?

Copy link
Contributor Author

@sreeramIfx sreeramIfx Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved into the cpu node

@sreeramIfx sreeramIfx force-pushed the topic/cyw20829_pm branch 2 times, most recently from 4c878f5 to 4b48f56 Compare October 8, 2024 05:34
ifyall
ifyall previously approved these changes Oct 8, 2024
View reviewed changes
@sreeramIfx sreeramIfx requested a review from gmarull October 8, 2024 18:54
gmarull
gmarull previously requested changes Oct 9, 2024
View reviewed changes
soc/infineon/cat1b/cyw20829/CMakeLists.txt Outdated
Copy link
Member

@gmarull gmarull Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
zephyr_sources_ifdef(CONFIG_PM ./power.c)
zephyr_sources_ifdef(CONFIG_PM power.c)

dts/arm/infineon/cat1b/cyw20829/cyw20829.dtsi Outdated
Copy link
Member

@gmarull gmarull Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

soc/infineon/cat1b/cyw20829/Kconfig.defconfig Outdated
Copy link
Member

@gmarull gmarull Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default n

soc/infineon/cat1b/cyw20829/power.c Outdated
Copy link
Member

@gmarull gmarull Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__weak void pm_state_set(enum pm_state state, uint8_t substate_id)
void pm_state_set(enum pm_state state, uint8_t substate_id)

soc/infineon/cat1b/cyw20829/power.c Outdated
Copy link
Member

@gmarull gmarull Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__weak void pm_state_exit_post_ops(enum pm_state state, uint8_t substate_id)
void pm_state_exit_post_ops(enum pm_state state, uint8_t substate_id)

soc/infineon/cat1b/cyw20829/power.c Outdated
Copy link
Member

@gmarull gmarull Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 board selective code in soc, find a better way

soc/infineon/cat1b/cyw20829/soc.c Outdated
Comment on lines 103 to 105
Copy link
Member

@gmarull gmarull Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ifdefout the entire hook?

ifyall
ifyall previously approved these changes Oct 9, 2024
View reviewed changes
@sreeramIfx sreeramIfx requested a review from gmarull October 9, 2024 20:35
gmarull
gmarull reviewed Oct 10, 2024
View reviewed changes
soc/infineon/cat1b/cyw20829/power.h Outdated
Comment on lines 11 to 13
Copy link
Member

@gmarull gmarull Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used anywhere

Copy link
Member

@gmarull gmarull Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping, impl still there

Copy link
Contributor Author

@sreeramIfx sreeramIfx Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmarull removed the implementation as well, please review

@sreeramIfx sreeramIfx requested a review from gmarull October 11, 2024 05:03
@sreeramIfx
soc: infineon: Support for power management on 20829
3cea7c8 
- Initial changes in board, dts, and soc files to support
 system power management

Signed-off-by: Sreeram Tatapudi <[email protected]>
@gmarull gmarull dismissed their stale review October 29, 2024 10:34

addressed

@sreeramIfx sreeramIfx requested a review from ifyall November 5, 2024 00:12
@nashif nashif merged commit 0a9c0f4 into zephyrproject-rtos:main Nov 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ifyall ifyall ifyall approved these changes

@parthitce parthitce Awaiting requested review from parthitce

@talih0 talih0 Awaiting requested review from talih0

@gmarull gmarull Awaiting requested review from gmarull

+1 more reviewer

@npal-cy npal-cy npal-cy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ifyall ifyall

Labels

platform: Infineon Infineon Technologies AG

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sreeramIfx @gmarull @ifyall @npal-cy @nashif @zephyrbot