driver: regulator: Add support for AXP2101 PMIC #78098
Conversation
|
Sorry, the previous one has been closed by a mistake. #77804 |
There was a problem hiding this comment.
Please align the name to the datasheet notation.
Here, ldoa1-> aldo1.
The others so on.
There was a problem hiding this comment.
It is also needed to fix dts and commit messages.
There was a problem hiding this comment.
Please create a header file in include/zephyr/drivers/mfd/
and move these definitions in the same as done in AXP192.
|
@ranranff Please use |
ranranff
force-pushed
the
main
branch
2 times, most recently
from
11f3ee0 to
eedb7a4
Compare
Add initial driver for the AXP2101 PMIC Support: - DCDC1-5 - LDOA1-A4, LDOB1-B2, LDOC1, LDOD1-D2 Signed-off-by: Deng Baoan <[email protected]>
ranranff
force-pushed
the
main
branch
2 times, most recently
from
11f3ee0 to
7aebc00
Compare
| LOG_INSTANCE_PTR_DECLARE(log); | ||
| }; | ||
|
|
||
| /*! ----------------------------------------------------------------------------------------*/ |
There was a problem hiding this comment.
Comment style should be follow https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style
| reg: | ||
| required: true | ||
|
|
||
| vbus-enable: |
There was a problem hiding this comment.
Is it currently used? If no, remove it.
| compatible: "x-powers,axp2101" | ||
|
|
||
| include: i2c-device.yaml | ||
|
|
There was a problem hiding this comment.
Please define bus. Such like,
bus: axp2101
| LOG_INST_DBG(config->log, "[0x%02x]=0x%02x mask=0x%02x", config->desc->enable_reg, | ||
| config->desc->enable_val, config->desc->enable_mask); | ||
|
|
||
| /* special case for LDOIO0, which is multiplexed with GPIO0 */ |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
4 participants
Add initial driver for the AXP2101 PMIC
Support:
Change-Id: I3f93900423ec592a44d7e80a4353672c63cfa3a4