Bluetooth: CCP: Add support for set/get provider name #79324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
ccp_server_name
branch
12 times, most recently
from
a3736c9 to
45c90ee
Compare
Thalley
force-pushed
the
ccp_server_name
branch
from
45c90ee to
d59830c
Compare
Thalley
force-pushed
the
ccp_server_name
branch
2 times, most recently
from
32eb534 to
cd67949
Compare
Thalley
force-pushed
the
ccp_server_name
branch
3 times, most recently
from
bb73153 to
8daccea
Compare
Thalley
force-pushed
the
ccp_server_name
branch
2 times, most recently
from
878f797 to
605ccf5
Compare
Thalley
force-pushed
the
ccp_server_name
branch
from
605ccf5 to
3fb1868
Compare
Thalley
force-pushed
the
ccp_server_name
branch
2 times, most recently
from
d27cd2a to
b983872
Compare
Thalley
force-pushed
the
ccp_server_name
branch
from
e8190da to
e8263ee
Compare
Thalley
force-pushed
the
ccp_server_name
branch
from
e8263ee to
0b3b827
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- doc/connectivity/bluetooth/shell/audio/ccp.rst: Language not supported
- subsys/bluetooth/audio/Kconfig.ccp: Language not supported
- subsys/bluetooth/audio/Kconfig.tbs: Language not supported
Comments suppressed due to low confidence (1)
include/zephyr/bluetooth/audio/ccp.h:101
- There is an inconsistency between the documentation using CONFIG_BT_TBS_MAX_PROVIDER_NAME_LENGTH and the implementation using CONFIG_BT_ccp_call_control_server_PROVIDER_NAME_MAX_LENGTH. Consider using the same macro for clarity.
* @retval -EINVAL @p bearer or @p name is NULL, or @p name is the empty string or @p name is larger than @kconfig{CONFIG_BT_TBS_MAX_PROVIDER_NAME_LENGTH}
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- doc/connectivity/bluetooth/shell/audio/ccp.rst: Language not supported
- subsys/bluetooth/audio/Kconfig.ccp: Language not supported
- subsys/bluetooth/audio/Kconfig.tbs: Language not supported
larsgk
reviewed
Apr 7, 2025
subsys/bluetooth/audio/Kconfig.ccp
Outdated
| help | ||
| The number of supported telephone bearers on the CCP Call Control Server | ||
|
|
||
| config BT_ccp_call_control_server_PROVIDER_NAME_MAX_LENGTH |
Contributor
Author
There was a problem hiding this comment.
Bad search-and-replace :D
Thalley
force-pushed
the
ccp_server_name
branch
2 times, most recently
from
87370d0 to
e32debc
Compare
Thalley
force-pushed
the
ccp_server_name
branch
from
e32debc to
81c70c1
Compare
Thalley
force-pushed
the
ccp_server_name
branch
2 times, most recently
from
8d4b884 to
1e7191c
Compare
Thalley
force-pushed
the
ccp_server_name
branch
2 times, most recently
from
419a9d6 to
a20843a
Compare
larsgk
approved these changes
Aug 14, 2025
Thalley
force-pushed
the
ccp_server_name
branch
from
e925515 to
d162d69
Compare
Add support for setting and getting the bearer provider name. For now the name will be duplicated by the TBS implementation, but will be optimizied in the future so only one copy of the name exists. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
ccp_server_name
branch
from
d162d69 to
b43d2c8
Compare
|
cvinayak
approved these changes
Sep 4, 2025
Contributor
cvinayak
left a comment
cvinayak
left a comment
There was a problem hiding this comment.
This has been there so long!
Contributor
Author
It almost has a 1-year anniversary :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for setting and getting the bearer provider
name. For now the name will be duplicated by the TBS
implementation, but will be optimizied in the future
so only one copy of the name exists.