Skip to content

Conversation

@rettichschnidi
Copy link
Contributor

By sorting the lines alphabetically, conflicts can be reduced. This (partially) replaces #76674.

Background

For a while now, I am working on support for a new SoC. Often, when rebasing my WIP branch on the most recent main, conflicts happen because everyone adds new drivers at the bottom. By biting the bullet now, this kind of conflict can (most of the time) be avoided in the future.

@rettichschnidi rettichschnidi mentioned this pull request Oct 3, 2024
@rettichschnidi rettichschnidi marked this pull request as ready for review October 3, 2024 23:19
@zephyrbot zephyrbot added the area: SPI SPI bus label Oct 3, 2024
@zephyrbot zephyrbot requested review from tbursztyka and teburd October 3, 2024 23:20
@rettichschnidi rettichschnidi force-pushed the gardena/rs/upstream/sim3u-sort-lines-spi branch from ab7a7aa to 8d33c90 Compare October 4, 2024 00:41
@rettichschnidi rettichschnidi changed the title drivers: spi: Prevent conflicts drivers: spi: Sort CMake and Kconfig files alphabetically Oct 4, 2024
tbursztyka
tbursztyka previously approved these changes Oct 21, 2024
@rettichschnidi
Copy link
Contributor Author

Rebased and force pushed due to conflicts.

tbursztyka
tbursztyka previously approved these changes Oct 22, 2024
kartben
kartben previously approved these changes Nov 25, 2024
By sorting the lines alphabetically, merge conflicts can be reduced.

Signed-off-by: Reto Schneider <[email protected]>
@rettichschnidi rettichschnidi dismissed stale reviews from kartben and tbursztyka via 845ca1c November 26, 2024 09:23
@rettichschnidi rettichschnidi force-pushed the gardena/rs/upstream/sim3u-sort-lines-spi branch from cff80b3 to 845ca1c Compare November 26, 2024 09:23
@rettichschnidi
Copy link
Contributor Author

@teburd @tbursztyka Please (re) review

@kartben kartben self-assigned this Dec 5, 2024
@kartben
Copy link
Contributor

kartben commented Dec 5, 2024

Only change is a rebase since @tbursztyka approved as assignee

@kartben kartben merged commit ea205bc into zephyrproject-rtos:main Dec 5, 2024
24 checks passed
@rettichschnidi rettichschnidi deleted the gardena/rs/upstream/sim3u-sort-lines-spi branch July 8, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: SPI SPI bus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants