drivers: serial: Sort CMake and Kconfig files alphabetically #79392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dcpleung
approved these changes
Oct 4, 2024
dcpleung
requested changes
Oct 4, 2024
Member
dcpleung
left a comment
dcpleung
left a comment
There was a problem hiding this comment.
Actually, the commit message should be about what is being done, in this case, sorting the cmake and kconfig. Simply saying "prevent conflicts" is not going to help others looking at the commit message.
By sorting the lines alphabetically, merge conflicts can be reduced. Signed-off-by: Reto Schneider <[email protected]>
rettichschnidi
force-pushed
the
gardena/rs/upstream/sim3u-sort-lines-serial
branch
from
99fc56b to
582c990
Compare
rettichschnidi
changed the title
dcpleung
approved these changes
Oct 4, 2024
rettichschnidi
deleted the
gardena/rs/upstream/sim3u-sort-lines-serial
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By sorting the lines alphabetically, conflicts can be reduced. This (partially) replaces #76674.
Background
For a while now, I am working on support for a new SoC. Often, when rebasing my WIP branch on the most recent main, conflicts happen because everyone adds new drivers at the bottom. By biting the bullet now, this kind of conflict can (most of the time) be avoided in the future.