Bluetooth: CCP: Client: Add get_bearers #79553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
changed the title
Thalley
force-pushed
the
ccp_client_get_bearers
branch
5 times, most recently
from
929b03d to
39409ab
Compare
Thalley
force-pushed
the
ccp_client_get_bearers
branch
from
39409ab to
aa81896
Compare
Thalley
force-pushed
the
ccp_client_get_bearers
branch
2 times, most recently
from
a48a329 to
2e236b8
Compare
Thalley
force-pushed
the
ccp_client_get_bearers
branch
3 times, most recently
from
717e065 to
0391afe
Compare
Thalley
force-pushed
the
ccp_client_get_bearers
branch
2 times, most recently
from
9f0a58e to
63e3385
Compare
Thalley
force-pushed
the
ccp_client_get_bearers
branch
from
63e3385 to
4246ad5
Compare
Thalley
force-pushed
the
ccp_client_get_bearers
branch
from
4246ad5 to
fa2a48a
Compare
Thalley
force-pushed
the
ccp_client_get_bearers
branch
from
fa2a48a to
c504d30
Compare
zephyrbot
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk and
niym-ot
Thalley
force-pushed
the
ccp_client_get_bearers
branch
from
c504d30 to
c4e4169
Compare
Thalley
force-pushed
the
ccp_client_get_bearers
branch
from
c4e4169 to
8863169
Compare
larsgk
previously approved these changes
Mar 13, 2025
Thalley
force-pushed
the
ccp_client_get_bearers
branch
from
8863169 to
b57934e
Compare
Thalley
force-pushed
the
ccp_client_get_bearers
branch
from
b57934e to
feb85df
Compare
Thalley
force-pushed
the
ccp_client_get_bearers
branch
from
feb85df to
5afbb07
Compare
include/zephyr/bluetooth/audio/ccp.h
Outdated
Comment on lines
197
to
198
| * @param[out] bearers The bearers struct that will be populated with the bearers of @p inst. | ||
| * @retval -EINVAL @p inst or @p bearers is NULL |
There was a problem hiding this comment.
The documentation for the 'bearers' parameter incorrectly references '@p inst' instead of '@p client'. Update the comment to correctly refer to the client parameter.
Suggested change
| * @param[out] bearers The bearers struct that will be populated with the bearers of @p inst. | |
| * @retval -EINVAL @p inst or @p bearers is NULL | |
| * @param[out] bearers The bearers struct that will be populated with the bearers of @p client. | |
| * @retval -EINVAL @p client or @p bearers is NULL |
Thalley
force-pushed
the
ccp_client_get_bearers
branch
from
5afbb07 to
1d3e47b
Compare
include/zephyr/bluetooth/audio/ccp.h
Outdated
| * @param[in] client The client to get the bearers of. | ||
| * @param[out] bearers The bearers struct that will be populated with the bearers of @p client. | ||
| * @retval 0 Succsss |
There was a problem hiding this comment.
Typo in the documentation: 'Succsss' should be corrected to 'Success'.
Suggested change
| * @retval 0 Succsss | |
| * @retval 0 Success |
Add bt_ccp_client_get_bearers that will return the bearers of a client so that the application can always retrieve them if they do not store them from the discovery callback. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
ccp_client_get_bearers
branch
from
1d3e47b to
2771439
Compare
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/bluetooth/audio/ccp_call_control_client/src/main.c:214
- Consider adding tests for negative cases to verify that bt_ccp_call_control_client_get_bearers returns -EINVAL when provided with NULL for either the client or bearers parameters.
static ZTEST_F(ccp_call_control_client_test_suite, test_ccp_call_control_client_get_bearers)
larsgk
approved these changes
Apr 7, 2025
babrsn
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bt_ccp_client_get_bearers that will return the bearers of
a client so that the application can always retrieve them if they
do not store them from the discovery callback.