test: bluetooth: Update ICS to TCRL 2024-2 #79667
Conversation
zephyrbot
added
area: Bluetooth
area: Bluetooth Qualification
|
note that when project is imported, Qualification Workspace will complain about ICS consistency check, this is due to https://bluetooth.atlassian.net/browse/ES-26148 (TCW is also available) |
What do we gain from adding this new TCLR? Could we wait until that (significant) erratum is fixed? |
|
TCRL 2024-2 is currently recommended for qualification (2024-1 is active only til early December), TBH I'm not sure on how such erratums are handled but I suspect that only next TCRL version will have this fixed (so for 2024-2 one has to use waiver anyway) |
|
Will try to import and check the changes soon to see what has changed :) |
There was a problem hiding this comment.
there is no support for " LE GATT Security Levels Characteristic"
There was a problem hiding this comment.
Ah, so it's a characteristic we don't have in Zephyr?
There was a problem hiding this comment.
yeap, although with dynamic gatt database it may not be that trivial to implement (unless we left this up to application...)
There was a problem hiding this comment.
Since we do not have our own LC3 codec, I don't think we should qualify it. Is is mandatory to add to the qualification?
There was a problem hiding this comment.
yeap, this is due to BAP
LC3 > BAP | If [CORE] (40/2) and [BAP] (93/1) are Supported then [LC3] (5/1) is Mandatory Go to Layer Selection.
but for true qualification one can refer to external QDID of their own codec, so this is just to make consistency check happy
There was a problem hiding this comment.
But we don't want to be running LC3 tests for Zephyr, as we do not provide that. Won't this enable a bunch of LC3 tests?
There was a problem hiding this comment.
no, LC3 is not tested with PTS (there are separate tools for that)
There was a problem hiding this comment.
For some reason this wasn't enabled when I imported this file :s
There was a problem hiding this comment.
afair ICS are imported only on 'new' profile, so you must first delete it from your workspace...
There was a problem hiding this comment.
Ditto: Not enabled on import
There was a problem hiding this comment.
This one was enabled though...
|
@sjanc since this PR is adding support for PAST, did you check if there are any values for BAP Broadcast Assistant and Scan Delegator that should be enabled that depend on PAST? |
I only checked that consistency is valid, I'll update this (I assume those are implemented, right?) |
|
ok, updated with enabled PAST related tests in BAP |
Thalley
left a comment
Thalley
left a comment
There was a problem hiding this comment.
Assuming that enabling the LC3 does not enable test cases specifically for LC3 I think this is OK. We just need to make sure we aren't overtesting the 3rd party LC3 codec :)
GAP PAST (and BAP) tests were also enabled since controller support is under review. This also adds bqw file which is exported draft project from Qualification Workspace. Signed-off-by: Szymon Janc <[email protected]>
|
Fixed MESH DFU->DFUM and MBT->MBTM, no other changes |
|
@carlescufi @nashif @MaureenHelm CRLF line ending override (forced merge) needed here again. |
5 participants
GAP PAST tests were also enabled since controller support is under review.
This also adds bqw file which is exported draft project from Qualification Workspace.