drivers: dma: si32: Improve enabling, disabling and configuration of DMA channels #79953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettichschnidi
force-pushed
the
gardena/rs/upstream/sim3u-dma-better-start-stop-config
branch
from
035dfc9 to
1c84afb
Compare
zephyrbot
added
platform: Silabs SiM3U
zephyrbot
requested review from
M1cha,
asmellby,
jerome-pouiller,
jhedberg and
teburd
jhedberg
reviewed
Oct 17, 2024
rettichschnidi
force-pushed
the
gardena/rs/upstream/sim3u-dma-better-start-stop-config
branch
from
1c84afb to
531a9c3
Compare
rettichschnidi
force-pushed
the
gardena/rs/upstream/sim3u-dma-better-start-stop-config
branch
from
531a9c3 to
8e3d578
Compare
jhedberg
previously approved these changes
Oct 17, 2024
teburd
reviewed
Oct 17, 2024
drivers/dma/dma_si32.c
Outdated
Contributor
There was a problem hiding this comment.
If the channel is not stopped this would be an error. See the DMA state diagrams https://docs.zephyrproject.org/latest/hardware/peripherals/dma.html#channel-state-machine-expectations
Let me know if something is unclear.
Contributor
Author
There was a problem hiding this comment.
Thanks a lot, feeling silly now. Need to rework this PR.
Contributor
Author
There was a problem hiding this comment.
Just pushed an improved version.
Regarding the documentation: It seem to me as if is missing the transition from Configured to Configured by using dma_config. Would create a PR for this if true. #80206
As per dma_stop() documentation, the implementation has to not just stop the transfer, but also to disable the channel. Before this commit, only the transfer has been stopped. Same goes for dma_start(). This also allows the enabling of a channel to be removed from dma_si32_config(). Signed-off-by: Reto Schneider <[email protected]>
rettichschnidi
force-pushed
the
gardena/rs/upstream/sim3u-dma-better-start-stop-config
branch
from
8e3d578 to
bf7cf51
Compare
Member
|
@rettichschnidi do you actually need the "reorder function definitions" commit anymore? |
As per Zephyr DMA documentation, dma_config() must not be done on a running channel. Signed-off-by: Reto Schneider <[email protected]>
rettichschnidi
force-pushed
the
gardena/rs/upstream/sim3u-dma-better-start-stop-config
branch
from
bf7cf51 to
4c82250
Compare
Contributor
Author
Gone |
jhedberg
approved these changes
Oct 22, 2024
teburd
approved these changes
Oct 22, 2024
rettichschnidi
deleted the
gardena/rs/upstream/sim3u-dma-better-start-stop-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves adherence to documented behavior and makes it harder to use the driver wrongly.