boards: shields: Add support for Adafruit AW9523 board #80112

soburi · 2024-10-20T17:22:23Z

Add support for Adafruit AW9523 GPIO Expander/LED Controller

I have checked this PR with nulceo_h503rb using the equivalent board as a circuit (https://www.waveshare.com/wiki/AW9523B_IO_Expansion_Board) to Adafruit AW9523.

kartben

Haven't reviewed the driver yet

kartben · 2024-11-07T01:23:04Z

boards/shields/adafruit_aw9523/adafruit_aw9523.overlay

I appreciate you taking the time to document this "convenience shortcut" you took but I think you would actually need to define a proper connector + conventional aliases for Qwiic since otherwise this will be problematic for people trying to use this shield on board that has both types of connectors IMO

I wholly revisited the description of the connector.

kartben · 2024-11-07T01:23:47Z

boards/shields/adafruit_aw9523/doc/adafruit_aw9523.jpg

Use webp format please. Bonus points if you can find a version with transparent background (not mandatory, but nice to have)

I changed the format to webp. I think the photos on the developer's page have the least copyright issues to quote, but unfortunately there were no photos with a white background here. Therefore, I did not change this.

boards/shields/adafruit_aw9523/doc/index.rst

kartben · 2024-11-07T01:26:48Z

boards/shields/adafruit_aw9523/doc/index.rst

Suggested change

This shield can only be used with a board which provides a configuration for

STEMMA QT/Qwiic or Grove.

This shield can only be used with a board which provides a configuration for

STEMMA QT/Qwiic.

kartben · 2024-11-07T01:27:12Z

boards/shields/adafruit_aw9523/doc/index.rst

What is this supposed to mean? Maybe a copy paste error?

Yes, that is correct.

fabiobaltieri · 2024-12-01T20:21:12Z

@erwango can you take a look at the shield part of this?

fabiobaltieri

good stuff, few more comments

dts/bindings/gpio/stemma-qt-connector.yaml

drivers/gpio/gpio_aw9523b.c

fabiobaltieri · 2024-12-04T10:37:19Z

drivers/gpio/gpio_aw9523b.c

I don't think you need to generate this, can you do

static __maybe_unused void gpio_aw9523b_int_handler(const struct device *gpio_dev, struct gpio_callback *cb, uint32_t pins) { struct gpio_aw9523b_data *data = CONTAINER_OF( cb, struct gpio_aw9523b_data, gpio_callback); k_work_submit(&data->intr_worker); }

instead? (copied it from input_paw32xx.c)

I worried about whether __maybe_unused can be used. It is standardized in C23, not C99.
If I can use it, it is better to use it.

It's pretty widely used in the code base, I wouldn't worry about that, just use it.

I got it. I applied your suggestion.

ok I see you added it on other callbacks but would you not use it to replace gpio_aw9523b_int_cb##inst with a common one as well? that was my main suggestion, this does not have to be generated, nothing wrong with it but it seems like unnecessary extra complexity

Ah, I misunderstood what you said.
This is better. I've addressed it.

dts/bindings/gpio/stemma-qt-connector.yaml

Add a definition of a STEMMA QT connector to which I2C devices can be connected. Since STEMMA-QT does not specify uses other than I2C, this is just a formal definition. (It may be helpful when using this connector as a GPIO, which is not defined in STEMMA-QT) Maybe in usual need to define i2c alias such like as, ``` stemma_qt_i2c: &i2c0 { } ``` Signed-off-by: TOKITA Hiroshi <[email protected]> Co-authored-by: Benjamin Cabé <[email protected]>

Add support for GPIO controller feature of AW9523B. Signed-off-by: TOKITA Hiroshi <[email protected]> Co-authored-by: Benjamin Cabé <[email protected]>

Add support for Adafruit AW9523 GPIO Expander/LED Controller Co-authored-by: Benjamin Cabé <[email protected]> Signed-off-by: TOKITA Hiroshi <[email protected]>

Add test configuration for Awinic AW9523B. This device is a GPIO Expander, and no boards currently implement it. Define the connection that connects it via the Arduino header and define a fixture to enable it. This has been confirmed with nucleo_h503rb. Signed-off-by: TOKITA Hiroshi <[email protected]>

Add test configuration for "awinic,aw9523b". Signed-off-by: TOKITA Hiroshi <[email protected]>

soburi added the DNM This PR should not be merged (Do Not Merge) label Oct 20, 2024

soburi marked this pull request as draft October 20, 2024 17:22

zephyrbot added area: MFD area: Shields Shields (add-on boards) area: GPIO labels Oct 20, 2024

zephyrbot requested review from aasinclair, avisconti, erwango, gmarull, henrikbrixandersen, jfischer-no, kartben and mnkp October 20, 2024 17:23

zephyrbot assigned kartben Oct 20, 2024

soburi force-pushed the awinic_aw9523b branch 2 times, most recently from b0fe39e to 5f6de7a Compare November 2, 2024 07:42

soburi changed the title ~~boards: shields: Add support for Adafruit AW9523 board~~ boards: shields: Add support for Adafruit AW9523B board Nov 4, 2024

soburi changed the title ~~boards: shields: Add support for Adafruit AW9523B board~~ boards: shields: Add support for Adafruit AW9523 board Nov 4, 2024

soburi force-pushed the awinic_aw9523b branch 3 times, most recently from ea2446a to 5066d2c Compare November 4, 2024 08:34

soburi removed the DNM This PR should not be merged (Do Not Merge) label Nov 4, 2024

soburi added this to the v4.1.0 milestone Nov 4, 2024

soburi force-pushed the awinic_aw9523b branch 3 times, most recently from 5bd20ee to e282c3f Compare November 4, 2024 11:15

soburi marked this pull request as ready for review November 4, 2024 12:59

soburi force-pushed the awinic_aw9523b branch from 53a81fa to 375316d Compare November 7, 2024 00:07

kartben requested changes Nov 7, 2024

View reviewed changes

soburi force-pushed the awinic_aw9523b branch from 375316d to ded48eb Compare November 9, 2024 09:29

soburi dismissed nordicjm’s stale review via c528068 December 3, 2024 12:25

soburi force-pushed the awinic_aw9523b branch from 8d41b9f to c528068 Compare December 3, 2024 12:25

zephyrbot assigned kartben Dec 3, 2024

soburi force-pushed the awinic_aw9523b branch 2 times, most recently from 89152c8 to c0d8a8c Compare December 3, 2024 12:57

soburi requested a review from fabiobaltieri December 3, 2024 13:35

soburi force-pushed the awinic_aw9523b branch 2 times, most recently from 176202d to 17be358 Compare December 4, 2024 06:32

fabiobaltieri reviewed Dec 4, 2024

View reviewed changes

soburi force-pushed the awinic_aw9523b branch from 17be358 to fbb5d99 Compare December 4, 2024 12:15

fabiobaltieri reviewed Dec 4, 2024

View reviewed changes

dts/bindings/gpio/stemma-qt-connector.yaml Outdated Show resolved Hide resolved

soburi force-pushed the awinic_aw9523b branch 3 times, most recently from ddf6b2c to c20cd23 Compare December 4, 2024 16:15

fabiobaltieri previously approved these changes Dec 4, 2024

View reviewed changes

fabiobaltieri requested review from kartben and nordicjm December 4, 2024 19:31

soburi and others added 6 commits December 5, 2024 06:31

drivers: gpio: Add support for Awinic AW9523B GPIO controller

7062024

Add support for GPIO controller feature of AW9523B. Signed-off-by: TOKITA Hiroshi <[email protected]> Co-authored-by: Benjamin Cabé <[email protected]>

boards: shields: Add support for Adafruit AW9523 board

b44d8ca

Add support for Adafruit AW9523 GPIO Expander/LED Controller Co-authored-by: Benjamin Cabé <[email protected]> Signed-off-by: TOKITA Hiroshi <[email protected]>

tests: drivers: build_all: gpio: Add config for AW9523B

a27d303

Add test configuration for "awinic,aw9523b". Signed-off-by: TOKITA Hiroshi <[email protected]>

soburi dismissed fabiobaltieri’s stale review via a27d303 December 4, 2024 21:35

soburi force-pushed the awinic_aw9523b branch from c20cd23 to a27d303 Compare December 4, 2024 21:35

fabiobaltieri approved these changes Dec 4, 2024

View reviewed changes

kartben approved these changes Dec 5, 2024

View reviewed changes

kartben merged commit 2953c38 into zephyrproject-rtos:main Dec 5, 2024
24 checks passed

soburi deleted the awinic_aw9523b branch December 5, 2024 06:59

-This shield can only be used with a board which provides a configuration for
-STEMMA QT/Qwiic or Grove.
+This shield can only be used with a board which provides a configuration for
+STEMMA QT/Qwiic.

boards: shields: Add support for Adafruit AW9523 board #80112

boards: shields: Add support for Adafruit AW9523 board #80112

Uh oh!

Conversation

soburi commented Oct 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kartben left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabiobaltieri commented Dec 1, 2024

Uh oh!

fabiobaltieri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabiobaltieri Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabiobaltieri Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

soburi commented Oct 20, 2024 •

edited

Loading

fabiobaltieri Dec 4, 2024 •

edited

Loading

fabiobaltieri Dec 4, 2024 •

edited

Loading