kernel: Add k_thread_runtime_stats_is_enabled function #80450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rruuaanng
force-pushed
the
gh80363
branch
2 times, most recently
from
fc52903 to
075a033
Compare
rruuaanng
changed the title
zephyrbot
requested review from
TaiJuWu,
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre and
peter-mitsis
rruuaanng
force-pushed
the
gh80363
branch
2 times, most recently
from
70b4aa0 to
04e6d25
Compare
cfriedt
reviewed
Oct 26, 2024
cfriedt
requested changes
Oct 27, 2024
rruuaanng
force-pushed
the
gh80363
branch
2 times, most recently
from
5302a73 to
e9323cc
Compare
|
I've made change, Please riewer again! |
ycsin
reviewed
Oct 28, 2024
peter-mitsis
previously approved these changes
Oct 28, 2024
ycsin
previously approved these changes
Oct 29, 2024
peter-mitsis
previously approved these changes
Apr 16, 2025
ycsin
previously approved these changes
Apr 17, 2025
cfriedt
previously approved these changes
Apr 17, 2025
|
@rruuaanng this needs another rebase |
rruuaanng
dismissed stale reviews from cfriedt, ycsin, and peter-mitsis
via
45a24db
|
@rruuaanng - Looks like this has conflicts that need to get resolved. |
andyross
previously approved these changes
Jul 1, 2025
| * @param thread ID of thread | ||
| * @return true if usage statistics are enabled for the given thread, otherwise false | ||
| */ | ||
| bool k_thread_runtime_stats_is_enabled(k_tid_t thread); |
There was a problem hiding this comment.
If this just depends on the thread struct, that header appears in the include paths already. You can make this inline without worry and save a few code bytes for users.
There was a problem hiding this comment.
Maybe we should stick to the existing API style? It looks like there are no static inline functions in kernel.h.
Add 'k_thread_runtime_stats_is_enabled' function, whichs used to check whether runtime statistics collection is enabled for a thread. Signed-off-by: James Roy <[email protected]>
Add test for 'k_thread_runtime_stats_is_enabled(tid)'. Signed-off-by: James Roy <[email protected]>
Add the `k_thread_runtime_stats_is_enabled` function to check if runtime statistics are enabled. Signed-off-by: James Roy <[email protected]>
|
I will open a new PR to finish the POSIX part, just to avoid any confusion. |
|
peter-mitsis
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'k_thread_runtime_stats_is_enabled' to 'usage.c', which's used to check whether runtime statistics collection is enabled for a thread.
It can determine whether the thread has enabled runtime statistics collection when the program is running. It allows users to add conditional statements based on this function when using it.
for example:
And it can provide a complete support when similar operations are needed. for example
enable,disable,is_enabled.For example, its use in the implementation of CLOCK_THREAD_CPUTIME_ID actually lacks k_thread_runtime_stats_is_enabled, which makes the entire function impossible to implement safely. It is necessary.
..