tests: Bluetooth: ISO: Add validation of unicast info #81029
+161
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
iso_unicast_info_validation
branch
2 times, most recently
from
6b89acc to
b3c1e05
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
2 times, most recently
from
9942c46 to
ec4105b
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
ec4105b to
ed46fef
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
ed46fef to
85730cf
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
85730cf to
63c688a
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
2 times, most recently
from
914d1d5 to
acc88d1
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
2 times, most recently
from
b41ce81 to
bd3ab72
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
bd3ab72 to
f6525a7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
f6525a7 to
7236f9f
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
7236f9f to
3feaf4f
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
3feaf4f to
db1188f
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
db1188f to
3e59c91
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
2 times, most recently
from
321c7c1 to
bd71d2f
Compare
zephyrbot
added
area: Bluetooth Host
zephyrbot
requested review from
HaavardRei,
alwa-nordic,
cvinayak,
hermabe and
jhedberg
1 task
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive validation of ISO channel information that applications can retrieve using bt_iso_chan_get_info. The changes introduce test assertions to verify the correctness of ISO channel configuration parameters and synchronization delays.
Key changes:
- Validation of ISO channel type, intervals, and synchronization delays
- Testing of transport latency, flush timeout, PDU size, PHY, and burst number parameters
- Addition of HCI constants for minimum and maximum values used in validation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/bsim/bluetooth/host/iso/cis/src/cis_peripheral.c | Added comprehensive validation of ISO channel info in peripheral role with bidirectional QoS configuration |
| tests/bsim/bluetooth/host/iso/cis/src/cis_central.c | Added ISO channel info validation in central role and refactored CIG parameter handling to use global variable |
| include/zephyr/bluetooth/hci_types.h | Added HCI constant definitions for sync delay and transport latency validation ranges |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
bd71d2f to
331eea3
Compare
alwa-nordic
approved these changes
Sep 3, 2025
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
331eea3 to
69e539d
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
69e539d to
1f703d7
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
1f703d7 to
a6c2845
Compare
zephyrbot
added
the
area: Tests
Add validation of the info the application can retrieve by calling bt_iso_chan_get_info. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
a6c2845 to
88303a2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation of the info the application can retrieve by calling bt_iso_chan_get_info.