Skip to content

Conversation

@peter-mitsis
Copy link
Contributor

@peter-mitsis peter-mitsis commented Nov 7, 2024

Corrects an issue that was introduced when the interrupt locking/unlocking was added to the 'sched' benchmark by unlocking the interrupts before the context switch done by k_yield(), but after the call to z_unpend_first_thread().

Fixes #81050

Corrects an issue that was introduced when the interrupt
locking/unlocking was added to the 'sched' benchmark by
unlocking the interrupts before the context switch done by
k_yield(), but after the call to z_unpend_first_thread().

Fixes PR zephyrproject-rtos#81050

Signed-off-by: Peter Mitsis <[email protected]>
@zephyrbot zephyrbot added size: XS A PR changing only a single line of code area: Benchmarks labels Nov 7, 2024
@zephyrbot zephyrbot requested review from dcpleung and nashif November 7, 2024 22:23
@peter-mitsis peter-mitsis requested a review from ycsin November 7, 2024 22:36
Copy link
Member

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works on qemu_riscv64_smp, thanks.

Can we also add qemu_riscv64_smp to the list of platforms in the testcase?

@mmahadevan108 mmahadevan108 added this to the v4.0.0 milestone Nov 8, 2024
@mmahadevan108 mmahadevan108 added the bug The issue is a bug, or the PR is fixing a bug label Nov 8, 2024
@mmahadevan108 mmahadevan108 merged commit aeaddd7 into zephyrproject-rtos:main Nov 8, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Benchmarks bug The issue is a bug, or the PR is fixing a bug size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests: benchmarks: sched: qemu_riscv assertion fail

6 participants