From 64a58fa618ee1ab8d055807106b2efe9f0031f20 Mon Sep 17 00:00:00 2001 From: Tarang Raval Date: Sun, 10 Nov 2024 14:31:23 +0530 Subject: [PATCH 1/4] drivers: sensor: fxls8974: Remove redundant error check The function fxls8974_get_temp_data always returns zero, indicating success. Therefore, the error checking if condition is unnecessary and can be removed. Signed-off-by: Tarang Raval --- drivers/sensor/nxp/fxls8974/fxls8974.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/sensor/nxp/fxls8974/fxls8974.c b/drivers/sensor/nxp/fxls8974/fxls8974.c index 049f289da84e0..b54f4eaadc4e1 100644 --- a/drivers/sensor/nxp/fxls8974/fxls8974.c +++ b/drivers/sensor/nxp/fxls8974/fxls8974.c @@ -379,9 +379,8 @@ static int fxls8974_channel_get(const struct device *dev, val += FXLS8974_MAX_ACCEL_CHANNELS; - if (fxls8974_get_temp_data(dev, val)) { - return -EIO; - } + return fxls8974_get_temp_data(dev, val); + break; case SENSOR_CHAN_ACCEL_XYZ: return fxls8974_get_accel_data(dev, val, SENSOR_CHAN_ACCEL_XYZ); From dcf546e5e387f66a053ba0a9319c4f6c1ec38eaf Mon Sep 17 00:00:00 2001 From: Tarang Raval Date: Sun, 10 Nov 2024 15:04:09 +0530 Subject: [PATCH 2/4] drivers: sensor: ina219: remove redundant error check The function ina219_set_msr_delay always returns zero, indicating success. Therefore, the error check on its return value is unnecessary and can be removed. Signed-off-by: Tarang Raval --- drivers/sensor/ti/ina219/ina219.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/sensor/ti/ina219/ina219.c b/drivers/sensor/ti/ina219/ina219.c index cebe0dc812a33..2560d879b8cf1 100644 --- a/drivers/sensor/ti/ina219/ina219.c +++ b/drivers/sensor/ti/ina219/ina219.c @@ -269,11 +269,7 @@ static int ina219_init(const struct device *dev) } /* Set measurement delay */ - rc = ina219_set_msr_delay(dev); - if (rc) { - LOG_ERR("Could not get measurement delay."); - return rc; - } + ina219_set_msr_delay(dev); k_sleep(K_USEC(INA219_WAIT_STARTUP)); From 3dfca6a74f9282d8bc49668c627183a0ef9f2054 Mon Sep 17 00:00:00 2001 From: Tarang Raval Date: Sun, 10 Nov 2024 16:04:42 +0530 Subject: [PATCH 3/4] Revert "drivers: sensor: ina219: remove redundant error check" This reverts commit dcf546e5e387f66a053ba0a9319c4f6c1ec38eaf. --- drivers/sensor/ti/ina219/ina219.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/sensor/ti/ina219/ina219.c b/drivers/sensor/ti/ina219/ina219.c index 2560d879b8cf1..cebe0dc812a33 100644 --- a/drivers/sensor/ti/ina219/ina219.c +++ b/drivers/sensor/ti/ina219/ina219.c @@ -269,7 +269,11 @@ static int ina219_init(const struct device *dev) } /* Set measurement delay */ - ina219_set_msr_delay(dev); + rc = ina219_set_msr_delay(dev); + if (rc) { + LOG_ERR("Could not get measurement delay."); + return rc; + } k_sleep(K_USEC(INA219_WAIT_STARTUP)); From 53c6430b6b2af3c9e468dbba3967243c422fc391 Mon Sep 17 00:00:00 2001 From: Tarang Raval Date: Sun, 10 Nov 2024 16:06:44 +0530 Subject: [PATCH 4/4] drivers: sensor: ina219: remove redundant error check The function ina219_set_msr_delay always returns zero, indicating success. Therefore, the error check on its return value is unnecessary and can be removed. Signed-off-by: Tarang Raval --- drivers/sensor/ti/ina219/ina219.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/sensor/ti/ina219/ina219.c b/drivers/sensor/ti/ina219/ina219.c index cebe0dc812a33..2560d879b8cf1 100644 --- a/drivers/sensor/ti/ina219/ina219.c +++ b/drivers/sensor/ti/ina219/ina219.c @@ -269,11 +269,7 @@ static int ina219_init(const struct device *dev) } /* Set measurement delay */ - rc = ina219_set_msr_delay(dev); - if (rc) { - LOG_ERR("Could not get measurement delay."); - return rc; - } + ina219_set_msr_delay(dev); k_sleep(K_USEC(INA219_WAIT_STARTUP));