tests: pwm_loopback: Capture disable omission issue #81198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikbrixandersen
previously approved these changes
Nov 19, 2024
anangl
reviewed
Nov 19, 2024
Comment on lines
103
to
109
Member
There was a problem hiding this comment.
This change is not really related to missing pwm_disable_capture() calls. It should be done in a separate commit.
Contributor
Author
There was a problem hiding this comment.
Moved to a separate commit.
Contributor
Author
There was a problem hiding this comment.
Removed
ioannis-karachalios
force-pushed
the
test-pwm-loopback-missing-capture-disable-fix
branch
from
e51ea82 to
9f49762
Compare
As per the PWM API definition, -EBUSY should be returned when pwm_enable_capture is called and capturing is already enabled. This commit deals with adding a ztest_suite_before_t function that should disable capturing at the end of a single test. Some tests, though, such as test_pulse_capture, execute two sub-tests and so, capturing is disabled in between. In fact, the omission of pwm_disable_capture should not only result in aborting a single test, but it can also raise system exception due to invalid context. This is the case for z_impl_pwm_capture_cycles where z_pwm_capture_cycles_callback can be fired whilst the routine has already aborted and so struct z_pwm_capture_cb_data data, defined within function declaration, should not longer be valid. Signed-off-by: Ioannis Karachalios <[email protected]>
ioannis-karachalios
force-pushed
the
test-pwm-loopback-missing-capture-disable-fix
branch
from
9f49762 to
8c93121
Compare
For the inverted pulse measurements, that should reflect the duty-cycle off interval, the 1% deviation in test_capture should be adjusted so it reflects duty-cycle off. Signed-off-by: Ioannis Karachalios <[email protected]>
anangl
approved these changes
Nov 26, 2024
Contributor
|
ping @henrikbrixandersen, if you could please re-approve |
henrikbrixandersen
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-EBUSYshould be returned whenpwm_enable_captureis called while capturingis already enabled. This commit should deal with adding a
ztest_suite_before_tfunction that should disable capturing.Some tests, though, such as
test_pulse_capture, execute two sub-tests and so, capturing is disabled in between.In fact, the omission of
pwm_disable_captureshould not only result in aborting a single test, but it can also raise system exception due to invalid context. This is the case forz_impl_pwm_capture_cycleswherez_pwm_capture_cycles_callbackcan be fired whilst the routine has already aborted (without disabling capturing) and sostruct z_pwm_capture_cb_data data, defined within function declaration, should not longer be valid.test_captureshould be adjusted so it reflects duty-cycle off.Fixes #81199