Add support for IPV6_MULTICAST_IF and IP_MULTICAST_IF socket options #81280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Sockets
zephyrbot
requested review from
cfriedt,
pdgendt,
rlubos,
ssharks,
tbursztyka and
ycsin
rlubos
previously approved these changes
Nov 12, 2024
jukkar
force-pushed
the
devel/add-ipv6-multicast-if-option
branch
2 times, most recently
from
b8b05ac to
7ba4736
Compare
Member
Author
|
jukkar
changed the title
jukkar
force-pushed
the
devel/add-ipv6-multicast-if-option
branch
from
7ba4736 to
8ad8f38
Compare
rlubos
previously approved these changes
Nov 18, 2024
Contributor
rlubos
left a comment
rlubos
left a comment
There was a problem hiding this comment.
Looks good, just one suggestion.
Allow user to set the network interface for multicast sockets of type SOCK_DGRAM. Signed-off-by: Jukka Rissanen <[email protected]>
Some of the network tests require that source and destination addresses are not swapped so allow test to control the address swapping from the test. Signed-off-by: Jukka Rissanen <[email protected]>
Add tests that verify that IPV6_MULTICAST_IF socket option set/get works as expected. Signed-off-by: Jukka Rissanen <[email protected]>
Do the selection same way as in IPv6 so that if user supplies unspecified destination address, the default interface is selected the same way. Signed-off-by: Jukka Rissanen <[email protected]>
This is helper is only needed in socket multicast interface selection where we need to get one address from the interface so that it will tell (when getsockopt() is used), the interface IPv4 address where multicast packets will be sent. This is private function which is not needed in public headers so place the prototype to net_private.h file. Signed-off-by: Jukka Rissanen <[email protected]>
Allow user to set the network interface for multicast sockets of type SOCK_DGRAM. Signed-off-by: Jukka Rissanen <[email protected]>
Add tests that verify that IP_MULTICAST_IF socket option set/get works as expected. Signed-off-by: Jukka Rissanen <[email protected]>
Make sure that we cannot connect to IPv4 multicast or broadcast destination address for a TCP socket. Signed-off-by: Jukka Rissanen <[email protected]>
jukkar
force-pushed
the
devel/add-ipv6-multicast-if-option
branch
from
8ad8f38 to
cb8144e
Compare
Member
Author
|
rlubos
approved these changes
Nov 18, 2024
Member
Author
|
@pdgendt if you have time, please take a look, and thanks in advance! |
cfriedt
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to set the network interface for IPv6 and IPv4 multicast sockets.