Skip to content

Conversation

@ycsin
Copy link
Member

@ycsin ycsin commented Nov 14, 2024

Rename the eeprom to test_eeprom to avoid namespace collision with boards that have existing eeprom defined in the devicetree, such as the adp_xc7k/ae350

To repro on main:

west build -p -b adp_xc7k/ae350 tests/drivers/build_all/eeprom -T drivers.eeprom.emul.build

and expect the following error:

-- Found devicetree overlay: /home/ycsin/zephyrproject/zephyr/tests/drivers/build_all/eeprom/app.overlay
devicetree error: Label 'eeprom' appears on /soc/i2c@f0a00000/eeprom@50 and on /test/i2c@11112222/tmp116@2/ti_tmp116_eeprom@0

This is failing in the CI of #81260

Rename the `eeprom` to `test_eeprom` to avoid namespace collision
with boards that have existing `eeprom` defined in the devicetree,
such as the `adp_xc7k/ae350`

Signed-off-by: Yong Cong Sin <[email protected]>
Signed-off-by: Yong Cong Sin <[email protected]>
@ycsin ycsin requested a review from soburi November 14, 2024 06:51
@zephyrbot zephyrbot added size: XS A PR changing only a single line of code area: EEPROM labels Nov 14, 2024
@ycsin ycsin added the Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. label Nov 14, 2024
@soburi
Copy link
Member

soburi commented Nov 14, 2024

Thank you for catching this problem.

@ycsin
Copy link
Member Author

ycsin commented Nov 14, 2024

Looks like @jimmyzhe was already there, closed.

@ycsin ycsin closed this Nov 14, 2024
@ycsin ycsin deleted the pr/fix-eeprom-build_all-test branch November 14, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: EEPROM Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants