soc: nordic: common: Add MRAM latency manager #81381
Conversation
zephyrbot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
soc/nordic/common/mram_latency.c
Outdated
There was a problem hiding this comment.
is only application expected to call this API?
There was a problem hiding this comment.
I've split the init into 2 stages, first onoff manager is initialized and then nrfs. Requests that comes before nrfs is initialized will not get completion notification until nrfs is initialized.
soc/nordic/common/mram_latency.h
Outdated
There was a problem hiding this comment.
I'd try to be consistent with gpd: use some namespacing, place it under soc/nrf54h/..., headers nrf/mram_latency.h, etc.
There was a problem hiding this comment.
I did not put it in nrf54h because of nrf92 and took the similar approach to dmm. I can move it to nrf54h however i see that it is already a bit unclear with regards to include files (only gdp has it's own include path). Maybe we should have soc/nordic/include/nrf path?
soc/nordic/common/mram_latency.h
Outdated
There was a problem hiding this comment.
an additional sync API may be useful for simplicity, dealing with onoff is cumbersome
There was a problem hiding this comment.
added mram_no_latency_sync_request() and mram_no_latency_sync_release()
soc/nordic/common/mram_latency.c
Outdated
There was a problem hiding this comment.
is goto needed if no cleanup action is done>?
There was a problem hiding this comment.
i was initially logging rv so wanted to have one place. Removed label and gotos now.
nordic-krch
force-pushed
the
mram
branch
4 times, most recently
from
d3be0ac to
4b886b1
Compare
Add module for managing multiple requests for MRAM latency. Signed-off-by: Krzysztof Chruściński <[email protected]>
Add test for MRAM latency. Signed-off-by: Krzysztof Chruściński <[email protected]>
kl-cruz
left a comment
kl-cruz
left a comment
There was a problem hiding this comment.
Could you open related PR in sdk-zephyr?
|
@masz-nordic @anangl can you take a look? |
| /** @internal For test purposes only. */ | ||
| extern struct onoff_manager mram_latency_mgr; |
There was a problem hiding this comment.
If it's only for tests then why not place it in tests/boards/nrf/mram_latency/src/main.c?
9 participants
Add module for managing multiple requests for setting MRAM operations without the latency. Module is using onoff manager.