Skip to content

Conversation

@lucien-nxp
Copy link
Contributor

fix issue: #81371
remove rt1180_evk platforms on canbus/isotp/conformance case, this case has not yet been adapted

remove rt1180_evk platforms on canbus/isotp/conformance case

Signed-off-by: Lucien Zhao <[email protected]>
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these tests fail on those platforms, likely CAN is not working as it should there. The right approach would to either fix CAN for those platforms or remove can as a supported feature from those platforms.

Simply excluding these platforms from a failing test is not a solution, it's just hiding the problem.

Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these tests fail on those platforms, likely CAN is not working as it should there. The right approach would to either fix CAN for those platforms or remove can as a supported feature from those platforms.

Simply excluding these platforms from a failing test is not a solution, it's just hiding the problem.

@henrikbrixandersen
Copy link
Member

From a quick glance, I am guessing these platforms are hit by the same issue with CAN FD support in the FlexCAN driver/HAL as the FRDM-MCXN947 is. I'd suggest removing the nxp,flexcan-fd compatible from the FlexCAN instances on this platform for now, reducing support to CAN classic.

@lucien-nxp lucien-nxp closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants