Skip to content

Conversation

@Fymyte
Copy link
Contributor

@Fymyte Fymyte commented Nov 15, 2024

Documentation for *init_hooks were not generated on doc website. This was due to ill-formed doc-strings for those hooks.

@Fymyte Fymyte force-pushed the init/init-hooks-doc branch from b919499 to bd70ac6 Compare November 15, 2024 09:08
@rruuaanng
Copy link
Contributor

It's looks fine. Push to other reviewer.

Documentation for *init_hooks were not generated on doc website.
This was due to ill-formed doc-strings for those hooks.

Signed-off-by: Pierrick Guillaume <[email protected]>
@Fymyte Fymyte force-pushed the init/init-hooks-doc branch from bd70ac6 to f27cac1 Compare November 18, 2024 08:22
@Fymyte
Copy link
Contributor Author

Fymyte commented Nov 18, 2024

Rebased to fix conflicts. @rruuaanng should I ask someone in particular for review ?

@Fymyte
Copy link
Contributor Author

Fymyte commented Nov 21, 2024

Hi, sorry for bothering you @nashif. @carlescufi
I've seen you were the ones who introduced this file in the project. I don't know whom to ask for a review otherwise

@nashif nashif requested a review from kartben November 21, 2024 10:47
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Fymyte!

@nashif nashif added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Nov 21, 2024
@fabiobaltieri fabiobaltieri merged commit f716973 into zephyrproject-rtos:main Nov 21, 2024
27 checks passed
@Fymyte Fymyte deleted the init/init-hooks-doc branch November 21, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Documentation Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants