tests: posix: common: separate xsi streams to standalone test #81445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
requested changes
Nov 15, 2024
Member
cfriedt
left a comment
cfriedt
left a comment
There was a problem hiding this comment.
Please use xsi_streams as the option group name / directory name.
Pancakem
force-pushed
the
separate_posix_xopen_streams_to_standalone_test
branch
from
1287e47 to
26a057d
Compare
15 tasks
cfriedt
changed the title
posix.common contains testsuites that can be separated into smaller groups of tests. This change moves stropts into a singular testsuite at tests/posix/xsi_streams app directory. Signed-off-by: Marvin Ouma <[email protected]>
Pancakem
force-pushed
the
separate_posix_xopen_streams_to_standalone_test
branch
from
26a057d to
8b714ff
Compare
cfriedt
approved these changes
Nov 20, 2024
Member
cfriedt
left a comment
cfriedt
left a comment
There was a problem hiding this comment.
LGTM, but at some point, we should deprecate CONFIG_XOPEN_STREAMS and call it CONFIG_XSI_STREAMS to match the Option Group.
ycsin
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81492
posix.common contains testsuites that can be separated into smaller groups of tests. This change moves stropts into a singular testsuite at tests/posix/xopen_streams app directory.