doc: posix: update for POSIX_FILE_SYSTEM_R
#81475
Conversation
zephyrbot
added
Release Notes
zephyrbot
requested review from
cfriedt,
dkalowsk,
kartben and
mmahadevan108
Add section for POSIX_FILE_SYSTEM_R which contains only `readdir_r()`. Signed-off-by: Yong Cong Sin <[email protected]>
ycsin
force-pushed
the
pr/posix-readdir_r
branch
from
afe04b6 to
eacdd8f
Compare
|
Ya unfortunately it's too late. You may maybe submit a PR against the branch but I never remember if it's something we do or if submissions have to be handled as backports |
doc/releases/release-notes-4.0.rst
Outdated
There was a problem hiding this comment.
I think this is maybe Ok for a backport PR to v4.0.
However, looking into things a bit deeper, getpwnam_r(), getpwuid_r(), getgrgid_r(), and getgrnam_r() belong to a separate Option Group -
POSIX_SYSTEM_DATABASE_R. And the non-reentrant versions of these belong to the POSIX_SYSTEM_DATABASE Option Group, and _POSIX_THREAD_SAFE_FUNCTIONS is more of an Option / Feature Test Macro.
So really what we need here is a new Kconfig.system_database file with two new Kconfig options (same as the option group names).
_POSIX_THREAD_SAFE_FUNCTIONS should probably be a hidden Kconfig option that depends on other Kconfig values being enabled. Namely, CONFIG_POSIX_SYSTEM_DATABASE_R, CONFIG_POSIX_C_LANG_SUPPORT_R, CONFIG_POSIX_FILE_LOCKING, CONFIG_POSIX_FILE_SYSTEM_R.
And then of course modify the docs
https://pubs.opengroup.org/onlinepubs/9799919799/xrat/V4_subprofiles.html
There was a problem hiding this comment.
All of the above should be in a separate PR.
|
Very much missed the release. Happy to add to the 4.0.1 backport list though! |
|
@ycsin . Do you think you can move the changes from the 4.0 release notes to 4.1 release notes? |
Should we? The changes were introduced in 4.0, not 4.1. |
ycsin
force-pushed
the
pr/posix-readdir_r
branch
from
eacdd8f to
352f9e6
Compare
ycsin
changed the title
POSIX_FILE_SYSTEM_RPOSIX_FILE_SYSTEM_R
ycsin
changed the title
POSIX_FILE_SYSTEM_RPOSIX_FILE_SYSTEM_R
Mention the `_POSIX_THREAD_SAFE_FUNCTIONS` functions implemented in zephyrproject-rtos#74394. Signed-off-by: Yong Cong Sin <[email protected]>
Yes but it's already been released, so by definition there's no way the release notes can be updated after the fact. They're already there and won't change: https://docs.zephyrproject.org/4.0.0/releases/release-notes-4.0.html |
There was a problem hiding this comment.
Yup, we discussed setting up some kind of CI check to catch these.
|
I think I confused GitHub to the point that it won't reflect the changes of the PR branch anymore, recreated a PR without changes to the 4.0 release notes #81553 |
6 participants
Update the notes for
POSIX_FILE_SYSTEM_R, looks like I missed the v4 release