[Backport v4.0-branch] net: ethernet: bridge: Avoid null pointer access #82239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the packet cloning failed, bail out in order to avoid null pointer access. Fixes #81992 Coverity-CID: 434493 Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit ed0dcca)
We need to drop the cloned packet that was fed to the bridge instead of returning directly from the function. Without this change we have a buffer leak. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit c6a1af5)
zephyrbot
added
Backport
zephyrbot
requested review from
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
rlubos
approved these changes
Nov 28, 2024
pdgendt
approved these changes
Nov 28, 2024
jukkar
approved these changes
Nov 29, 2024
aescolar
approved these changes
Dec 3, 2024
dkalowsk
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c6a1af5~2..c6a1af5 from #82042.
Fixes #81992