[Backport v4.0-branch] net: wifi_cred: Check null before access #82286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must do null check before trying to access the fields. Fixes #81980 Coverify-CID: 434549 Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 3aa0c86)
Follow the net coding style and declare the variables at the start of the function. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit b2056e0)
Follow net coding style and remove extra new lines between variable set and checking its value. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 8deebce)
As the error print strings are very similar, construct the final output at runtime to save some flash space. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 3c59bd4)
zephyrbot
added
Backport
zephyrbot
requested review from
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
jukkar
approved these changes
Nov 29, 2024
rlubos
approved these changes
Dec 2, 2024
aescolar
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3c59bd4~4..3c59bd4 from #82045.
Fixes #81980